Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RoutedViewHost control implementation #2294

Merged
merged 6 commits into from Feb 17, 2019

Conversation

Projects
None yet
2 participants
@worldbeater
Copy link
Contributor

worldbeater commented Feb 10, 2019

What does the pull request do?

This PR adds a RoutedViewHost control implementation to Avalonia.ReactiveUI package. This is required for ReactiveUI view model based routing support.

What is the current behavior?

There is no RoutedViewHost control in Avalonia.ReactiveUI package.

What is the updated/expected behavior with this PR?

There is a RoutedViewHost control in Avalonia.ReactiveUI package.

How was the solution implemented (if it's not obvious)?

Inspired by WPF RoutedViewHost implementation and Xamarin.Forms RoutedViewHost implementation.

Checklist

  • Added XML documentation to any related classes
  • Added unit tests
  • Added usage examples

@worldbeater worldbeater changed the title [WIP] Add RoutedViewHost control implementation Add RoutedViewHost control implementation Feb 10, 2019

@grokys

grokys approved these changes Feb 15, 2019

Copy link
Member

grokys left a comment

LGTM!

grokys added some commits Feb 15, 2019

@grokys grokys merged commit 0f66c59 into AvaloniaUI:master Feb 17, 2019

2 checks passed

Avalonia (Pull Requests) Avalonia (Pull Requests) succeeded
Details
AvaloniaUI.Avalonia #20190217.8 succeeded
Details

@grokys grokys added this to the 0.8.0 milestone Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.