Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DropDown to ComboBox #2393

Merged
merged 5 commits into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@grokys
Copy link
Member

grokys commented Mar 26, 2019

What does the pull request do?

Renames DropDown to ComboBox to be consistent with WPF/UWP. Maintains a DropDown control that is marked as [Obsolete] to aid migration. When a DropDown is created via XAML also logs a warning.

Breaking changes

Users should migrate from DropDown to ComboBox.

grokys added some commits Mar 26, 2019

DropDown -> ComboBox.
Renamed `DropDown` to `ComboBox` to fit in with WPF/UWP.
Re-added an obsolete DropDown control.
To provide backwards compatibility for the moment.

@grokys grokys force-pushed the refactor/combobox branch from 0bb1636 to 1d06c7e Mar 26, 2019

@grokys grokys force-pushed the refactor/combobox branch from 1d06c7e to 6089291 Mar 26, 2019

@grokys grokys requested a review from AvaloniaUI/core Mar 26, 2019

@grokys grokys marked this pull request as ready for review Mar 26, 2019

@jmacato

jmacato approved these changes Apr 1, 2019

@grokys grokys merged commit fab0a72 into master Apr 1, 2019

1 of 2 checks passed

Avalonia (Pull Requests) Avalonia (Pull Requests) failed
Details
AvaloniaUI.Avalonia #20190401.3 succeeded
Details

@grokys grokys deleted the refactor/combobox branch Apr 1, 2019

@grokys grokys added this to the 0.8.0 milestone Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.