Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont handle f10 key in accesskey handler #2979

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@danwalmsley
Copy link
Member

commented Sep 11, 2019

What does the pull request do?

AccessKeyHandler handles F10 keyup event, and opens menu and focuses it.

The problem is if you want to use F10 in your application, after loss of focus, hotkeys are no longer detected. Because the menu retains focus.

Since this is barely used this PR removes this, and allows anyone to use F10 in their application without trouble.

What is the updated/expected behavior with this PR?

F10 can be handled without menu causing issues.

@danwalmsley danwalmsley changed the title dont handle f10 key in accesskey handler, prevents people using f10 h… dont handle f10 key in accesskey handler Sep 11, 2019

@grokys
grokys approved these changes Sep 11, 2019
Copy link
Member

left a comment

We need a way to add these sort of keys by platform, and to be able to override them, but as a quick fix this works for me.

@grokys grokys merged commit f9e7006 into master Sep 11, 2019

3 of 4 checks passed

Avalonia (Pull Requests) Avalonia (Pull Requests) failed
Details
AvaloniaUI.Avalonia #20190911.47 succeeded
Details
DEP All dependencies are resolved
WIP Ready for review
Details

@grokys grokys deleted the fix/remove-accesskeyhandler-f10 branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.