Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ManagedFileDialogFix from Wasabi Wallet #3232

Merged
merged 2 commits into from Nov 9, 2019

Conversation

@danwalmsley
Copy link
Member

danwalmsley commented Nov 8, 2019

What does the pull request do?

Backports a fix from Wasabi zkSNACKs/WalletWasabi#2508

What is the current behavior?

File name can be lost.

What is the updated/expected behavior with this PR?

Dont over write filename when no valid selection.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Fixed issues

danwalmsley added 2 commits Nov 8, 2019
@danwalmsley danwalmsley added this to To do in 0.9 Release via automation Nov 8, 2019
@jmacato
jmacato approved these changes Nov 9, 2019
@jmacato jmacato added this to the 0.9 milestone Nov 9, 2019
@jmacato jmacato merged commit b9251eb into master Nov 9, 2019
4 checks passed
4 checks passed
Avalonia (Pull Requests) Avalonia (Pull Requests) succeeded
Details
AvaloniaUI.Avalonia #20191108.25 succeeded
Details
DEP All dependencies are resolved
WIP Ready for review
Details
0.9 Release automation moved this from To do to Done Nov 9, 2019
@jmacato jmacato deleted the prevent-filename-cleared-managed-file-dialog branch Nov 9, 2019
FileName = SelectedItems.FirstOrDefault()?.DisplayName;
var selectedItem = SelectedItems.FirstOrDefault();

if (selectedItem != null)

This comment has been minimized.

Copy link
@kekekeks

kekekeks Nov 9, 2019

Member

These lines are aligned with tabs instead of spaces

danwalmsley added a commit that referenced this pull request Nov 9, 2019
…aged-file-dialog

Backport of ManagedFileDialogFix from Wasabi Wallet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.9 Release
  
Done
3 participants
You can’t perform that action at this time.