Features zerowarnings: Changes which alter code and could affect functionality in the base library #4882
Conversation
workgroupengineering
force-pushed
the
features/zerowarnings_core
branch
from
6b63687
to
e6f48c5
Compare
|
hi @maxkatz6, i synchronized the PR with the latest commit of the master branch. When you have time you can review the PR again. |
|
@workgroupengineering we discussed this PR before, and we think it should be merged after 0.10 release. |
Thanks for the reply.
I asked this question to understand if I should continue to maintain this PR or should I abandon it. |
…eference types should only be used in code within
…nd IndeterminateEndingOffset
…perators and will run synchronously.
…ullable reference types should only be used in code within a '#nullable'
… doesn't match overridden member (possibly because of nullability attributes)
…n type of 'ICommand? MenuItem.Command.get' doesn't match implicitly implemented member 'ICommand ICommandSource.Command.get' (possibly because of nullability attributes).
…nter instead' Avalonia.Android
…ulture=neutral, PublicKeyToken=null' does not have a strong name.
workgroupengineering
force-pushed
the
features/zerowarnings_core
branch
from
8e7f719
to
91f9389
Compare
|
I have updated the PR, there are only 16 alerts. 14 of which are related to IME support for X11, I have not suppressed them as I don't know the implementation is complete. The other two are related to the creation of the nuget package on macOS and I have not yet understood what it depends on. Here C.I. Build. |
|
Would be nice to get this in soonish! CC: @grokys |
|
Definitely, I plan to work on this soon. Looking at the changes, I feel there are still low impact changes and high-impact changes mixed together so I think I need to go through the PR and either separate the two types of changes out or do a very thorough review. |
There was a problem hiding this comment.
@workgroupengineering I started reviewing this but then I figured that it'll just be easier to cherry pick the parts of this PR that are correct and fix the parts that I'm confident of the correct fix. I will open a new PR and add you as a co-author to the commits.
The PR probably won't fix all the issues (because as you've seen, it's difficult to fix some warnings if you don't know the code well) so I will leave this PR open to track remaining warnings. Thanks for all your work here!
Co-Authored-By: workgroupengineering <workgroupengineering@users.noreply.github.com>
|
I updated the PR according to your instructions. |
What does the pull request do?
Split PR #4499
#4499 (comment)