Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Add ReadPixels OpenGL function #6067

Closed
wants to merge 1 commit into from
Closed

- Add ReadPixels OpenGL function #6067

wants to merge 1 commit into from

Conversation

DrunkyBard
Copy link
Contributor

What does the pull request do?

Add missing glReadPixels function

What is the updated/expected behavior with this PR?

Function is not used in Avalonia source code. It's needed for my custom render target implementation.

@dnfadmin
Copy link

dnfadmin commented Jun 14, 2021

CLA assistant check
All CLA requirements met.

@kekekeks
Copy link
Member

Here is an example of importing extra functions on per-app basis. The built-in GlInterface is meant to be used for only essentials that are required to setup Avalonia rendering, so we aren't expanding it for anything else.

Note that quite soon (in 2-3 weeks) there will be OpenTK integration.

@DrunkyBard
Copy link
Contributor Author

Ok, thanks for pointing out to that example. I guess PR could be rejected

@Gillibald
Copy link
Contributor

As mentioned by @kekekeks there is no intention to add extra functionality to GlInterface that isn't directly used by Avalonia

@Gillibald Gillibald closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants