Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial update #71

Merged
merged 5 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@HankG
Copy link
Contributor

commented May 9, 2019

What kind of change does this PR introduce?
Updates dotnet command line parameters and outputs to be consistent with clarifications as necessary.

What is the current behavior?

  • Project creation command had wrong template name
  • Project created file hierarchy was not consistent with current outputs
  • View creation steps don't mention default rather than specific namespace when using command line

What is the new behavior?

  • Updated project creation template name
  • Updated project hierarchy listing with additional details for new files
  • Warning note about the needing to change the default namespace before compiling.
@@ -88,6 +88,11 @@ namespace Todo.Views
We're not going to touch the code-behind file for a little while, but notice that the class is
called `TodoListView` and it's located in the `Todo.Views` namespace.

**NOTE: If you created this from the dotnet command line tool the namespace in the auto-generated

This comment has been minimized.

Copy link
@grokys

grokys May 11, 2019

Member

I think actually we should be using the -na|--namespace switch to set the namespace when creating the template. See https://github.com/AvaloniaUI/avalonia-dotnet-templates#creating-a-new-usercontrol and https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-new?tabs=netcore21

This comment has been minimized.

Copy link
@HankG

HankG May 13, 2019

Author Contributor

I'll update the command line to include that to fix that problem. I was trying to meander my way through the command line help and I didn't see that.

This comment has been minimized.

Copy link
@HankG

HankG May 14, 2019

Author Contributor

...removed note and added the namespace parameter in the latest revision...

@@ -72,6 +76,8 @@ You can see there are directories for each of the concepts in the MVVM pattern (
- The **App.xaml** file is where XAML styles and templates that will apply to the entire application will be placed.
- The **Program.cs** file is the entry point for execution of the application. Here you can configure the platform options for Avalonia if necessary.
- The **ViewLocator.cs** file is used to look up views for view models. This will be explained in more detail later.
- The **nuget.config** file is where the application's NuGet dependencies are specified
- The **Todo.csproj** file is the C# Project file that specifies project settings, source paths, etc.

This comment has been minimized.

Copy link
@grokys

grokys May 11, 2019

Member

I didn't include these two files because they're not really specific to Avalonia and likely to be something that many users have encountered elsewhere. Do you think they need to be called out specifically?

This comment has been minimized.

Copy link
@HankG

HankG May 13, 2019

Author Contributor

I was on the fence on that too. I was thinking of it from the perspective of a new .NET developer as well as new Avalonia developer.

This comment has been minimized.

Copy link
@HankG

HankG May 14, 2019

Author Contributor

...removed these additional items in the latest revision...

HankG added some commits May 14, 2019

@grokys

grokys approved these changes May 16, 2019

Copy link
Member

left a comment

Thanks @HankG !

@grokys grokys merged commit a5968bd into AvaloniaUI:master May 16, 2019

2 checks passed

WIP Ready for review
Details
avaloniaui.net Build #20190514.2 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.