Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues in how last avs+ deal with the parameters #186

Closed
realfinder opened this issue Aug 16, 2020 · 9 comments
Closed

issues in how last avs+ deal with the parameters #186

realfinder opened this issue Aug 16, 2020 · 9 comments

Comments

@realfinder
Copy link

realfinder commented Aug 16, 2020

Hi,

seems there are bug or something for many cases like https://forum.doom9.org/showpost.php?p=1920166&postcount=622 and https://forum.doom9.org/showpost.php?p=1918913&postcount=5 and https://forum.doom9.org/showthread.php?p=1920018#post1920018 , AviSynth+ 3.5.X was fine with them

thanks

@pinterf
Copy link

pinterf commented Aug 18, 2020

Looking into it

@pinterf
Copy link

pinterf commented Aug 18, 2020

Fixed in commit 2d77f6d

@pinterf
Copy link

pinterf commented Aug 18, 2020

Hm. But it made problems with Stackvertical which has multiple clip inputs and if tried first with implicite "last", it will use StackVertical(last, clip1,clip2) for a StackVertical(clip1,clip2)
Edit: this is good for both worlds.
8a64a7c

# this DOESN'T work:
colorbars
Animate(0,100,"blur",0.1,1.5)

Animate is special in the way that it has two function signatures: "iis." and "ciis."
Passing the parameters with the syntax above will find the "clipless" version. Animate is created O.K.
When its internal expression parameter "blur" is evaluated later, it turnes out that it requires a clip. But it's too late, function with the matching (clipless) function signature was already chosen and Invoking "Animate" as a whole will fail and giving a function arguments error.

When such function parameter error exception is thrown, Avisynth will try to give a second changce and find the appropriate function with a forced clip ("last") variable.

@realfinder
Copy link
Author

realfinder commented Aug 18, 2020

GWriteFileIf case still not fixed

@pinterf
Copy link

pinterf commented Aug 24, 2020

Found something, need some more time. The array of strings parameters for WriteFileIf
.WriteFileIf(scFile, "boolSC==true", "current_frame")
was not recognized against the "s+" parameter specifier.
(The "boolSC==true" and the "current_frame" parameters are moved into an array in the calling situation above)

@pinterf
Copy link

pinterf commented Aug 31, 2020

Could you please check this build (common with the current win10 long filename support test):
https://drive.google.com/file/d/1h-CyjQPEvmj6ZZgYbYUY1pgrp8eovr9w/view?usp=sharing

@realfinder
Copy link
Author

I did a test with https://forum.doom9.org/showthread.php?p=1918893#post1918893 and it's now work fine, thanks

@pinterf
Copy link

pinterf commented Sep 1, 2020

Fixed in ac90e98

@realfinder
Copy link
Author

so I will close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants