Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for node 0.10: use setImmediate() #22

Merged
merged 2 commits into from Mar 12, 2013

Conversation

Projects
None yet
2 participants

kschzt commented Mar 12, 2013

In node 0.10 using recursive process.nextTick() calls breaks ('resulting in a maximum call stack size exceeded'). Use setImmediate() instead.

kschzt commented Mar 12, 2013

If/when landing this, please cherry-pick it onto a new 0.2.x tag so that fs-extra will take the fix in without a new version/publish. Thanks! ;)

Owner

AvianFlu commented Mar 12, 2013

While your change is the correct one, it needs to remain backwards-compatible, and still use process.nextTick for all pre-0.9 versions of node. I've been meaning to make this change for a while, but haven't had the chance.

If you've got the time to add a version check and a fallback for 0.8, I'll merge it presently; otherwise, I'll add it later today myself.

Thanks, regardless!

kschzt commented Mar 12, 2013

@AvianFlu Ah right, done.

Owner

AvianFlu commented Mar 12, 2013

Awesome! Since it's backwards-compatible, a new 0.2.x it is. Merging presently.

Thanks!

kschzt commented Mar 12, 2013

Thanks a lot :)

Owner

AvianFlu commented Mar 12, 2013

Actually, I haven't looked at my own versions in a while... I'm up to 0.4.0. I'd love to help you guys out with your dependency needs, but it seems like a strange release to make at this point.

Thoughts?

@AvianFlu AvianFlu merged commit c1de4d6 into AvianFlu:master Mar 12, 2013

Owner

AvianFlu commented Mar 12, 2013

Nevermind, it took my brain a little while to catch up to what you were asking for with the 0.2.x release above. Long day. Cherry-picking presently.

Owner

AvianFlu commented Mar 12, 2013

@kschzt 0.2.7 published. Thanks again for the fix, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment