Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(oidc):preload user (alpha) #1352

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

guillaume-chervet
Copy link
Contributor

A picture tells a thousand words

Before this PR

After this PR

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-1352.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-1352.westeurope.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-1352.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-1352.westeurope.2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-rock-0dc6b0d03-1352.westeurope.1.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-glacier-004ab4303-1352.westeurope.2.azurestaticapps.net

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@guillaume-chervet guillaume-chervet merged commit 64c76e0 into main Apr 23, 2024
14 of 17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/preload-user branch April 23, 2024 01:28
hminsky2002 added a commit to PhilanthropyDataCommons/front-end that referenced this pull request Apr 24, 2024
This commit updates the @axa-fr/react-oidc package to it's latest
version, 7.22.4 (NOTE: This version was released yesterday), to use it's
latest feature, user preload. Currently, the useOidcUser hook runs
async, which makes it a pain to couple with subsequent hooks. However,
[as added in the latest
version](AxaFrance/oidc-client#1352), we can
explicitly set a configuration variable to await the loading of the user
data. Since we need to grapple the oidc user authentication id with the
authentication id in the database in order to get the DATABASE user id,
which is also done via an async hook, this seems like the correct
approach.

Issue #702 Get User's Id For Use in Dependent API Calls
seems to be the correct approach until
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant