From 64f239ef721c5b9a208de64f2ebb6971b77e48a6 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Thu, 7 Feb 2019 16:21:01 +0000 Subject: [PATCH 1/2] refactor(collapse) clean code --- examples/demo/package-lock.json | 30 ++++++++++++++----- package-lock.json | 28 ++++++++++++----- packages/Form/Input/card/package-lock.json | 2 +- .../Form/Input/checkbox/package-lock.json | 2 +- packages/Form/Input/choice/package-lock.json | 2 +- packages/Form/Input/date/package-lock.json | 2 +- packages/Form/Input/file/package-lock.json | 2 +- packages/Form/Input/number/package-lock.json | 2 +- packages/Form/Input/pass/package-lock.json | 2 +- packages/Form/Input/radio/package-lock.json | 2 +- .../Form/Input/select-multi/package-lock.json | 2 +- packages/Form/Input/select/package-lock.json | 2 +- packages/Form/Input/slider/package-lock.json | 2 +- packages/Form/Input/switch/package-lock.json | 2 +- packages/Form/Input/text/package-lock.json | 2 +- packages/Form/core/package-lock.json | 2 +- packages/Form/filter-inline/package-lock.json | 2 +- packages/Form/filter/package-lock.json | 2 +- packages/Form/steps/package-lock.json | 2 +- packages/Form/summary/package-lock.json | 2 +- .../Layout/footer-client/package-lock.json | 2 +- packages/Layout/footer/package-lock.json | 2 +- packages/Layout/header/package-lock.json | 2 +- packages/Modal/boolean/package-lock.json | 2 +- packages/Modal/default/package-lock.json | 2 +- packages/action/package-lock.json | 2 +- packages/alert/package-lock.json | 2 +- packages/badge/package-lock.json | 2 +- packages/button/package-lock.json | 2 +- packages/collapse/package-lock.json | 2 +- packages/collapse/src/CollapseCardBase.js | 14 +++++---- packages/core/package-lock.json | 2 +- packages/help/package-lock.json | 2 +- packages/highlight/package-lock.json | 2 +- packages/icon/package-lock.json | 2 +- packages/link/package-lock.json | 2 +- packages/list/package-lock.json | 2 +- packages/loader/package-lock.json | 2 +- packages/panel/package-lock.json | 2 +- packages/popover/package-lock.json | 2 +- packages/status/package-lock.json | 2 +- packages/table/package-lock.json | 2 +- packages/title/package-lock.json | 2 +- storybook/storybook/package-lock.json | 2 +- storybook/styles/package-lock.json | 30 ++++++++++++++----- 45 files changed, 115 insertions(+), 69 deletions(-) diff --git a/examples/demo/package-lock.json b/examples/demo/package-lock.json index 49519b2e2..53c1a499c 100644 --- a/examples/demo/package-lock.json +++ b/examples/demo/package-lock.json @@ -1,6 +1,6 @@ { "name": "sample-app", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -5991,11 +5991,13 @@ }, "balanced-match": { "version": "1.0.0", - "bundled": true + "bundled": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -6008,15 +6010,18 @@ }, "code-point-at": { "version": "1.1.0", - "bundled": true + "bundled": true, + "optional": true }, "concat-map": { "version": "0.0.1", - "bundled": true + "bundled": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", - "bundled": true + "bundled": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -6119,7 +6124,8 @@ }, "inherits": { "version": "2.0.3", - "bundled": true + "bundled": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -6129,6 +6135,7 @@ "is-fullwidth-code-point": { "version": "1.0.0", "bundled": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -6141,17 +6148,20 @@ "minimatch": { "version": "3.0.4", "bundled": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } }, "minimist": { "version": "0.0.8", - "bundled": true + "bundled": true, + "optional": true }, "minipass": { "version": "2.2.4", "bundled": true, + "optional": true, "requires": { "safe-buffer": "^5.1.1", "yallist": "^3.0.0" @@ -6168,6 +6178,7 @@ "mkdirp": { "version": "0.5.1", "bundled": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -6240,7 +6251,8 @@ }, "number-is-nan": { "version": "1.0.1", - "bundled": true + "bundled": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -6250,6 +6262,7 @@ "once": { "version": "1.4.0", "bundled": true, + "optional": true, "requires": { "wrappy": "1" } @@ -6355,6 +6368,7 @@ "string-width": { "version": "1.0.2", "bundled": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", diff --git a/package-lock.json b/package-lock.json index e12fbe58e..46381af74 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13366,12 +13366,14 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -13386,17 +13388,20 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -13513,7 +13518,8 @@ "inherits": { "version": "2.0.3", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -13525,6 +13531,7 @@ "version": "1.0.0", "bundled": true, "dev": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -13539,6 +13546,7 @@ "version": "3.0.4", "bundled": true, "dev": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -13546,12 +13554,14 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "minipass": { "version": "2.2.4", "bundled": true, "dev": true, + "optional": true, "requires": { "safe-buffer": "^5.1.1", "yallist": "^3.0.0" @@ -13570,6 +13580,7 @@ "version": "0.5.1", "bundled": true, "dev": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -13650,7 +13661,8 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -13662,6 +13674,7 @@ "version": "1.4.0", "bundled": true, "dev": true, + "optional": true, "requires": { "wrappy": "1" } @@ -13783,6 +13796,7 @@ "version": "1.0.2", "bundled": true, "dev": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", diff --git a/packages/Form/Input/card/package-lock.json b/packages/Form/Input/card/package-lock.json index 7c1a237e4..f9efc1edb 100644 --- a/packages/Form/Input/card/package-lock.json +++ b/packages/Form/Input/card/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-card", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/checkbox/package-lock.json b/packages/Form/Input/checkbox/package-lock.json index 8f0bab470..9c2a8834a 100644 --- a/packages/Form/Input/checkbox/package-lock.json +++ b/packages/Form/Input/checkbox/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-checkbox", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/choice/package-lock.json b/packages/Form/Input/choice/package-lock.json index e1da36301..f80f4864b 100644 --- a/packages/Form/Input/choice/package-lock.json +++ b/packages/Form/Input/choice/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-choice", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/date/package-lock.json b/packages/Form/Input/date/package-lock.json index 4d5f5d68f..cd6da3dc2 100644 --- a/packages/Form/Input/date/package-lock.json +++ b/packages/Form/Input/date/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-date", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/file/package-lock.json b/packages/Form/Input/file/package-lock.json index 819f32a4d..0b67faa04 100644 --- a/packages/Form/Input/file/package-lock.json +++ b/packages/Form/Input/file/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-file", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/number/package-lock.json b/packages/Form/Input/number/package-lock.json index 5091e77cc..09624a9f6 100644 --- a/packages/Form/Input/number/package-lock.json +++ b/packages/Form/Input/number/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-number", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/pass/package-lock.json b/packages/Form/Input/pass/package-lock.json index f3c4e1a17..7f707de0f 100644 --- a/packages/Form/Input/pass/package-lock.json +++ b/packages/Form/Input/pass/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-pass", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/radio/package-lock.json b/packages/Form/Input/radio/package-lock.json index c07e19128..5de83bf78 100644 --- a/packages/Form/Input/radio/package-lock.json +++ b/packages/Form/Input/radio/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-radio", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/select-multi/package-lock.json b/packages/Form/Input/select-multi/package-lock.json index ba2fd6eb8..fe8ebbd52 100644 --- a/packages/Form/Input/select-multi/package-lock.json +++ b/packages/Form/Input/select-multi/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-select-multi", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/select/package-lock.json b/packages/Form/Input/select/package-lock.json index af9e3166a..dd322f151 100644 --- a/packages/Form/Input/select/package-lock.json +++ b/packages/Form/Input/select/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-select", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/slider/package-lock.json b/packages/Form/Input/slider/package-lock.json index cf6f3eed0..972d4b5a8 100644 --- a/packages/Form/Input/slider/package-lock.json +++ b/packages/Form/Input/slider/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-slider", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/switch/package-lock.json b/packages/Form/Input/switch/package-lock.json index 7b32bd10b..dd4d78bc1 100644 --- a/packages/Form/Input/switch/package-lock.json +++ b/packages/Form/Input/switch/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-switch", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/Input/text/package-lock.json b/packages/Form/Input/text/package-lock.json index 04962f1eb..d56e999db 100644 --- a/packages/Form/Input/text/package-lock.json +++ b/packages/Form/Input/text/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-input-text", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/core/package-lock.json b/packages/Form/core/package-lock.json index 148f2cf92..a27810941 100644 --- a/packages/Form/core/package-lock.json +++ b/packages/Form/core/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-core", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/filter-inline/package-lock.json b/packages/Form/filter-inline/package-lock.json index 35d6aad29..3815a3f2e 100644 --- a/packages/Form/filter-inline/package-lock.json +++ b/packages/Form/filter-inline/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-filter-inline", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/filter/package-lock.json b/packages/Form/filter/package-lock.json index a7a63d829..daadbfa31 100644 --- a/packages/Form/filter/package-lock.json +++ b/packages/Form/filter/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-filter", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/steps/package-lock.json b/packages/Form/steps/package-lock.json index 4a3cdded2..fd068f494 100644 --- a/packages/Form/steps/package-lock.json +++ b/packages/Form/steps/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-steps", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Form/summary/package-lock.json b/packages/Form/summary/package-lock.json index 65c6b6213..2b36ec3de 100644 --- a/packages/Form/summary/package-lock.json +++ b/packages/Form/summary/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-form-summary", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Layout/footer-client/package-lock.json b/packages/Layout/footer-client/package-lock.json index fc957b78e..8ee6e4cdb 100644 --- a/packages/Layout/footer-client/package-lock.json +++ b/packages/Layout/footer-client/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-layout-footer-client", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Layout/footer/package-lock.json b/packages/Layout/footer/package-lock.json index 0adc50b4e..a1dcfae57 100644 --- a/packages/Layout/footer/package-lock.json +++ b/packages/Layout/footer/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-layout-footer", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Layout/header/package-lock.json b/packages/Layout/header/package-lock.json index 38a35474e..61d4dd471 100644 --- a/packages/Layout/header/package-lock.json +++ b/packages/Layout/header/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-layout-header", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Modal/boolean/package-lock.json b/packages/Modal/boolean/package-lock.json index db0f9c0dd..6a1137e9d 100644 --- a/packages/Modal/boolean/package-lock.json +++ b/packages/Modal/boolean/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-modal-boolean", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/Modal/default/package-lock.json b/packages/Modal/default/package-lock.json index 08c7484bb..307850baa 100644 --- a/packages/Modal/default/package-lock.json +++ b/packages/Modal/default/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-modal-default", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/action/package-lock.json b/packages/action/package-lock.json index 7cc076c6a..cd1b65abc 100644 --- a/packages/action/package-lock.json +++ b/packages/action/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-action", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/alert/package-lock.json b/packages/alert/package-lock.json index 155193ef3..f8c024755 100644 --- a/packages/alert/package-lock.json +++ b/packages/alert/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-alert", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/badge/package-lock.json b/packages/badge/package-lock.json index d9ffcd225..503e34cd8 100644 --- a/packages/badge/package-lock.json +++ b/packages/badge/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-badge", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/button/package-lock.json b/packages/button/package-lock.json index e8746ee0b..48accedd2 100644 --- a/packages/button/package-lock.json +++ b/packages/button/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-button", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/collapse/package-lock.json b/packages/collapse/package-lock.json index 87a6f5423..df6b705f3 100644 --- a/packages/collapse/package-lock.json +++ b/packages/collapse/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-collapse", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/collapse/src/CollapseCardBase.js b/packages/collapse/src/CollapseCardBase.js index 8b0cfdfb6..7579a95ad 100644 --- a/packages/collapse/src/CollapseCardBase.js +++ b/packages/collapse/src/CollapseCardBase.js @@ -1,7 +1,11 @@ import React, { Component } from 'react'; import PropTypes from 'prop-types'; -import { ClassManager, Constants, InputManager } from '@axa-fr/react-toolkit-core'; +import { + ClassManager, + Constants, + InputManager, +} from '@axa-fr/react-toolkit-core'; import Body from './Body'; import Header from './Header'; @@ -26,10 +30,9 @@ const defaultProps = { }; const getIds = id => { - const headerId = InputManager.getInputId(id); + const id = InputManager.getInputId(id); return { - headerId, - bodyId: InputManager.getInputId(`${headerId}body`), + id, }; }; @@ -60,7 +63,8 @@ class CollapseCardBase extends Component { renderChild(child) { const { collapse, onToggle, classModifier, index } = this.props; - const { headerId, bodyId } = this.state; + const { id: headerId } = this.state; + const bodyId = `${headerId}body`; if (child) { switch (child.type) { case Header: diff --git a/packages/core/package-lock.json b/packages/core/package-lock.json index 7b14099c9..94bdd0d4a 100644 --- a/packages/core/package-lock.json +++ b/packages/core/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-core", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/help/package-lock.json b/packages/help/package-lock.json index c005b1433..efd0e512c 100644 --- a/packages/help/package-lock.json +++ b/packages/help/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-help", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/highlight/package-lock.json b/packages/highlight/package-lock.json index 887f0379e..19c4ea417 100644 --- a/packages/highlight/package-lock.json +++ b/packages/highlight/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-highlight", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/icon/package-lock.json b/packages/icon/package-lock.json index 3a3b65468..9bcc12957 100644 --- a/packages/icon/package-lock.json +++ b/packages/icon/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-icon", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/link/package-lock.json b/packages/link/package-lock.json index e82b79e0b..9244fcb28 100644 --- a/packages/link/package-lock.json +++ b/packages/link/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-link", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/list/package-lock.json b/packages/list/package-lock.json index 1a632aaae..1aebdb0d1 100644 --- a/packages/list/package-lock.json +++ b/packages/list/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-list", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/loader/package-lock.json b/packages/loader/package-lock.json index 640207e1e..99a6f6517 100644 --- a/packages/loader/package-lock.json +++ b/packages/loader/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-loader", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/panel/package-lock.json b/packages/panel/package-lock.json index 3fc6287dc..63dfb9418 100644 --- a/packages/panel/package-lock.json +++ b/packages/panel/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-panel", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/popover/package-lock.json b/packages/popover/package-lock.json index 91caa8415..7e3e80efc 100644 --- a/packages/popover/package-lock.json +++ b/packages/popover/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-popover", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/status/package-lock.json b/packages/status/package-lock.json index ee4c371fc..15e5e0ed6 100644 --- a/packages/status/package-lock.json +++ b/packages/status/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-status", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/table/package-lock.json b/packages/table/package-lock.json index 70d99327e..77dba1ffb 100644 --- a/packages/table/package-lock.json +++ b/packages/table/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-table", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/title/package-lock.json b/packages/title/package-lock.json index 9a95db870..c3d80fd3a 100644 --- a/packages/title/package-lock.json +++ b/packages/title/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-title", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/storybook/storybook/package-lock.json b/storybook/storybook/package-lock.json index 2f27d555c..a77143bb8 100644 --- a/storybook/storybook/package-lock.json +++ b/storybook/storybook/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/react-toolkit-storybook", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/storybook/styles/package-lock.json b/storybook/styles/package-lock.json index 776755e07..eaa52a8b1 100644 --- a/storybook/styles/package-lock.json +++ b/storybook/styles/package-lock.json @@ -1,6 +1,6 @@ { "name": "@axa-fr/demo-css", - "version": "1.0.3", + "version": "1.0.5", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -5473,12 +5473,14 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -5493,17 +5495,20 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -5620,7 +5625,8 @@ "inherits": { "version": "2.0.3", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -5632,6 +5638,7 @@ "version": "1.0.0", "bundled": true, "dev": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -5646,6 +5653,7 @@ "version": "3.0.4", "bundled": true, "dev": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -5653,12 +5661,14 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "minipass": { "version": "2.2.4", "bundled": true, "dev": true, + "optional": true, "requires": { "safe-buffer": "^5.1.1", "yallist": "^3.0.0" @@ -5677,6 +5687,7 @@ "version": "0.5.1", "bundled": true, "dev": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -5757,7 +5768,8 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -5769,6 +5781,7 @@ "version": "1.4.0", "bundled": true, "dev": true, + "optional": true, "requires": { "wrappy": "1" } @@ -5890,6 +5903,7 @@ "version": "1.0.2", "bundled": true, "dev": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", From 802530553639678502642dc6a9f46cb93a8b1c19 Mon Sep 17 00:00:00 2001 From: Guillaume Chervet Date: Thu, 7 Feb 2019 16:22:59 +0000 Subject: [PATCH 2/2] maj --- packages/collapse/src/CollapseCardBase.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/collapse/src/CollapseCardBase.js b/packages/collapse/src/CollapseCardBase.js index 7579a95ad..f0a4a5ea5 100644 --- a/packages/collapse/src/CollapseCardBase.js +++ b/packages/collapse/src/CollapseCardBase.js @@ -30,9 +30,9 @@ const defaultProps = { }; const getIds = id => { - const id = InputManager.getInputId(id); + const newId = InputManager.getInputId(id); return { - id, + id: newId, }; };