From e5f55e60c8260286e13d1676f4946d4e0e91a935 Mon Sep 17 00:00:00 2001 From: Nana Mochihara Date: Tue, 2 Mar 2021 12:30:29 +0100 Subject: [PATCH] fix(simpletable): limit transition property --- .../src/SimpleTable/__snapshots__/index.test.tsx.snap | 8 ++++---- packages/core/src/SimpleTable/index.tsx | 6 +----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/packages/core/src/SimpleTable/__snapshots__/index.test.tsx.snap b/packages/core/src/SimpleTable/__snapshots__/index.test.tsx.snap index 487e0aa7..a4c6e00b 100644 --- a/packages/core/src/SimpleTable/__snapshots__/index.test.tsx.snap +++ b/packages/core/src/SimpleTable/__snapshots__/index.test.tsx.snap @@ -78,8 +78,8 @@ exports[`SimpleTable SimpleTable 1`] = ` width: 100%; height: 56px; text-align: left; - -webkit-transition: all 200ms; - transition: all 200ms; + -webkit-transition: box-shadow 200ms; + transition: box-shadow 200ms; cursor: pointer; } @@ -105,8 +105,8 @@ exports[`SimpleTable SimpleTable 1`] = ` width: 100%; height: 56px; text-align: left; - -webkit-transition: all 200ms; - transition: all 200ms; + -webkit-transition: box-shadow 200ms; + transition: box-shadow 200ms; opacity: 0.48; pointer-events: none; cursor: unset; diff --git a/packages/core/src/SimpleTable/index.tsx b/packages/core/src/SimpleTable/index.tsx index 5eb3e8f6..5b77ac37 100644 --- a/packages/core/src/SimpleTable/index.tsx +++ b/packages/core/src/SimpleTable/index.tsx @@ -96,9 +96,6 @@ const SimpleTableHeader: React.FC = ({ * SimpleTableRow * * A single row in the table used to group cells. - * Note that there is no div associated with this, - * it is just a convenience component to pass proper - * keys to the grid cells. */ const TableRow = styled.tr<{ @@ -115,7 +112,7 @@ const TableRow = styled.tr<{ text-align: left; - transition: all 200ms; + transition: box-shadow 200ms; &:nth-child(odd) { background-color: ${({ theme }) => theme.color.background03()}; @@ -246,7 +243,6 @@ interface SimpleTableProps extends BaseProps { readonly maxHeight: number /** * Override theme's default setting for `compact` if set. - */ readonly compact?: boolean /**