[#1035] Utilize TransactionManager on append events operation #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JpaEventStorageEngine should ensure that an appendEvents call is always performed within a transaction. To that end, the TransactionManager#executeInTransction(Runnable) function should be utilized to wrap the appending of events in a transaction #1035
smcvb
added
Type: Bug
smcvb
requested review from
abuijze,
m1l4n54v1c,
MGathier,
saratry and
gjmwoods
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensure that the
JpaEventStorageEngineuses theTransactionManagerto perform theappendEvents(List<EventMessage>, Serializer)call in a Transaction, always.Typically, this transaction is started by the
CommandGatewayis that's the starting point of entering an Aggregate/External Command Handler, and applying events as a result of that.However, if somebody would want to publish events directly when utilizing the
JpaEventStorageEngine, then that would form an issue from a Transaction perspective.This pull request resolve #1035