Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Introduce micrometer module #791
Since spring boot 2 removed dropwizard metrics in favour of micrometer I think it will be a good idea if the axon-metrics module also uses micrometer.
I didn't check the backward compatibility with spring boot 1 yet. Micrometer does support spring boot 1 via the legacy module: http://micrometer.io/docs/ref/spring/1.5. So presumably by adding the legacy module to a spring boot 1 application the axon-metrics module should work in the same way. It's hard to use automated tests to verify this since the axon-spring-boot-autoconfigure tests use spring boot 2. I'm not sure how important the backward compatibility with spring boot 1 is for the metrics module.
changed the title
Replaced dropwizard metrics with micrometer in metrics module
Sep 25, 2018
Made some changes to support metrics in Spring Boot 1 applications.
In order for the spring boot 1 actuator metrics endpoint to work there needs to be a dropwizard metricregistry. I added an auto configure class to add a micrometer wrapped dropwizard registry. This fixes the metrics endpoint.
I did remove the dropwizard-metrics dependency from the metrics module. So spring boot 1 users should add the dependency on dropwizard metrics to their own project.
That sounds like a fair idea..smart one.