From 9efca4c761202182ee52e986e1975b5ded8f85e3 Mon Sep 17 00:00:00 2001 From: Ayuei Date: Tue, 27 Jun 2023 12:56:20 +1000 Subject: [PATCH 1/2] Added elasticsearch config documentation --- src/debeir/core/config.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/debeir/core/config.py b/src/debeir/core/config.py index b76774a..9cb5799 100644 --- a/src/debeir/core/config.py +++ b/src/debeir/core/config.py @@ -168,6 +168,12 @@ def validate(self): class ElasticsearchConfig(Config): """ Basic Elasticsearch configuration file settings from the master nir.toml file + + Attributes: + protool (int): https or http. + ip: IP address of the elasticsearch index/cluster. + port: port of the elasticsearch index + timeout: the maximum time to wait for a request to finish. Recommended to set to 10 minutes, as dense retrieval is an expensive operation. """ protocol: str ip: str From bc5a1e6606fc2dc7edf3874060b07bde2a3ebd04 Mon Sep 17 00:00:00 2001 From: Ayuei Date: Tue, 27 Jun 2023 12:57:48 +1000 Subject: [PATCH 2/2] Comment on 10 minute ES default --- configs/elasticsearch.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/elasticsearch.toml b/configs/elasticsearch.toml index 65dec0a..72dbbd4 100644 --- a/configs/elasticsearch.toml +++ b/configs/elasticsearch.toml @@ -1,4 +1,4 @@ protocol = "http" ip = "127.0.0.1" port = "9200" -timeout = 600 \ No newline at end of file +timeout = 600 # 10 minutes timeout, dense retrieval requests are expensive and may take a while to return results