fix: Key normalization inconsistency#2
Merged
Conversation
Azhovan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a bug in which inconsistent key normalization caused binding failures:
Before:
Source keys: Fully lowercased (
strings.ToLower(key))Field keys: Only first letter lowercased (
APIKey→aPIKey)Result: Keys didn't match!
apikey≠aPIKeyWhy
name:tagswouldn't match normalized source keysType
Testing
TestBindStruct_MultiWordFields: Tests APIKey, MaxConnections, RetryTimeoutTestBindStruct_PrefixNormalization: Tests uppercase prefix tagsTestBindStruct_CustomNameNormalization: Tests uppercase name tagsTestDeriveFieldKey: Unit tests for key derivation functionChecklist
go test ./...)gofmt -s -w .)go vet ./...)For reviewers: Does this align with Rigging's philosophy of simplicity and zero dependencies?