Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat protocol audit nik naks #79

merged 14 commits into from Mar 28, 2019


None yet
1 participant
Copy link

zac-williamson commented Mar 26, 2019



Packages Updated


  • Prefix PR title with [WIP] if necessary.
  • Write tests for added code when needed.
  • Update documentation when needed.

zac-williamson added some commits Mar 23, 2019

changed 'toBytes' to 'toBytes5' and modified implementation
renamed `uint` to `uint256`

removed SafeMath when increasing 256-bit loop iterators

smart contract validators now reset free memory pointer after YUL validation code

commented NoteUtils and removed some unneccessary temporary variables
meta commit
added noteType variable into ABI encoding of notes

updated abiEncoder to encode/decode with noteType

updated JoinSplitABIEncoder to include noteType

updated DividendComputationABIEncoder to include noteType

updated BilateralSwapABIEncoder to include noteType

refactored BilateralSwapABIEncoder to contain 2 proofOutput entries consistent with a swap

added `eslint-import-resolver-lerna` dev-dependency at root level

updated NoteUtils.sol to expect new note format

added `getNoteType` method into NoteUtils.sol

updated computed note hashes to include noteType

changed JOIN_SPLIT_SIGNATURE EIP712 message to contain `bytes32 noteHash` instead of `bytes32[4] note`
fixed bug in zkAsset, where publicApprovals was not being correctly u…

fixed bug in test script that was preventing profile output from being run

wrote brief gas report

@zac-williamson zac-williamson merged commit 6b88e31 into audit Mar 28, 2019

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
ci/circleci: coverage Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
coverage/coveralls Coverage increased (+1.2%) to 89.413%

@ArnSch ArnSch deleted the feat-protocol-audit-nik-naks branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.