From cd1d7e90991d2fd7941a54d42c848f2121f84611 Mon Sep 17 00:00:00 2001 From: Mitchell Tracy Date: Thu, 29 Feb 2024 08:38:38 -0500 Subject: [PATCH] address PR feedback --- .../src/structs/kernel/combined_accumulated_data.ts | 12 ------------ .../src/sequencer/public_processor.test.ts | 3 ++- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/yarn-project/circuits.js/src/structs/kernel/combined_accumulated_data.ts b/yarn-project/circuits.js/src/structs/kernel/combined_accumulated_data.ts index 9ae4f024646..f15f9c5afff 100644 --- a/yarn-project/circuits.js/src/structs/kernel/combined_accumulated_data.ts +++ b/yarn-project/circuits.js/src/structs/kernel/combined_accumulated_data.ts @@ -34,8 +34,6 @@ import { ReadRequestContext } from '../read_request.js'; import { SideEffect, SideEffectLinkedToNoteHash } from '../side_effects.js'; import { NewContractData } from './new_contract_data.js'; -// const log = createDebugLogger('aztec:combined_accumulated_data'); - /** * Read operations from the public state tree. */ @@ -340,11 +338,6 @@ export class CombinedAccumulatedData { ...nonRevertible.publicDataUpdateRequests, ].filter(x => !x.isEmpty()); - // log.debug('nonSquashedWrites'); - // for (const write of nonSquashedWrites) { - // log.debug(write.toFriendlyJSON()); - // } - const squashedWrites = Array.from( nonSquashedWrites .reduce>((acc, curr) => { @@ -354,11 +347,6 @@ export class CombinedAccumulatedData { .values(), ); - // log.debug('squashedWrites'); - // for (const write of squashedWrites) { - // log.debug(write.toFriendlyJSON()); - // } - const publicDataUpdateRequests = padArrayEnd( squashedWrites, PublicDataUpdateRequest.empty(), diff --git a/yarn-project/sequencer-client/src/sequencer/public_processor.test.ts b/yarn-project/sequencer-client/src/sequencer/public_processor.test.ts index 761f9140702..d5013bed5ed 100644 --- a/yarn-project/sequencer-client/src/sequencer/public_processor.test.ts +++ b/yarn-project/sequencer-client/src/sequencer/public_processor.test.ts @@ -359,7 +359,8 @@ describe('public_processor', () => { proof, TxL2Logs.random(2, 3), TxL2Logs.random(3, 2), - callRequests.slice().reverse(), // unsure why we need to reverse here 😬 + // reverse because `enqueuedPublicFunctions` expects the last element to be the front of the queue + callRequests.slice().reverse(), [ExtendedContractData.random()], );