feat: AVM cutover — delete NAPI AVM, wire IPC simulator pool + CDB IPC server [PR 3b]#23154
Closed
charlielye wants to merge 4 commits into
Closed
feat: AVM cutover — delete NAPI AVM, wire IPC simulator pool + CDB IPC server [PR 3b]#23154charlielye wants to merge 4 commits into
charlielye wants to merge 4 commits into
Conversation
charlielye
requested review from
IlyasRidhuan,
MirandaWood and
jeanmon
as code owners
…rretenberg The link line was reduced to `barretenberg ipc` when stripping the NAPI AVM, but LMDBStore is still exported from nodejs_module and needs LMDB symbols (mdb_cursor_open etc). The all-in-one barretenberg archive does not pull in LMDB. world_state does (it owns the LMDB tree storage), and since LMDBStore itself is the only thing in nodejs_module that needs LMDB, depending on world_state is the right fit. Mirrors cl/wsdb_cdb.
Collaborator
|
This issue was automatically closed because it was referenced in PR #23040 which has been merged to the default branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts the in-process NAPI AVM over to the standalone
aztec-avmbinary (PR 3a) + a TS-hostedCdbIpcServerfor contract data callbacks. NAPI AVM and its TsCallback-based contracts DB are deleted.This is the third (and final) stage of the WSDB/AVM IPC architecture migration:
NAPI side (delete)
barretenberg/cpp/src/barretenberg/nodejs_module/avm_simulate/(NAPI AVM module + TS-callback contracts DB + utils).init_module.cpp;nodejs_module.nodenow exposes onlyLMDBStore,MsgpackClient,MsgpackClientAsync.NativeAvm/NativeAvmCancellationTokenexports from@aztec/native.TS side (rewire)
public_tx_simulator/cpp_public_tx_simulator.tsdrives anAvmIpcBackend(pool from PR 3a), returnsSimulationHandle { result, cancel }.public_tx_simulator/factories.tsreturns the IPC simulator for production block building and proving.public_processor+guarded_merkle_treeupdated for the newSimulationHandleandAvmIpcBackendtypes.public_tx_simulator/ipc_vs_ts_public_tx_simulator.tsadded as the new dual-run test helper (replacescpp_vs_ts_public_tx_simulator.ts).public_tx_simulator/dumping_cpp_public_tx_simulator.tsupdated to dump IPC msgpack inputs.Integration
aztec-node/src/aztec-node/server.tsspawnsAvmBackend+CdbIpcServeralongsideWsdbBackend.validator-client/checkpoint_builderandprover-nodewired through.txetest infra uses the same backends.Removed test
simulator/src/public/public_processor/apps_tests/timeout_race.test.ts— the bug it guarded against (in-process C++ AVM racing TS checkpoint reverts on the same WorldState handle) is structurally impossible once the AVM is a separate process. The cancellation path remains exercised throughSimulationHandle.cancel().Stack mechanics
Test plan