feat(ci): run aztec-cli acceptance test on macOS#23309
Merged
vezenovm merged 2 commits intoMay 19, 2026
Merged
Conversation
nchamo
changed the title
nchamo
commented
May 15, 2026
| with: | ||
| ref: ${{ github.event.workflow_run.head_sha || github.sha }} | ||
|
|
||
| # Node is only used to run the .ts harness in run-test.sh, which needs >=22.18 for TS |
Contributor
Author
There was a problem hiding this comment.
We are now handling this in run-test.sh
nchamo
commented
May 15, 2026
Comment on lines
+30
to
35
| # Install latest LTS node, since we need it to run the acceptance test correctly | ||
| export NVM_DIR="$HOME/.nvm" | ||
| set +eu; . "$NVM_DIR/nvm.sh"; set -eu | ||
| echo ">>> Installing latest LTS Node via NVM" | ||
| nvm install --lts | ||
| echo ">>> Installing aztec ${VERSION}" |
Contributor
Author
There was a problem hiding this comment.
We always install LTS node, so we can make sure we can run the test properly
nchamo
force-pushed
the
nchamo/f-566-explore-macos-ci-coverage-for-the-full-dev-onboarding-path
branch
from
57583e4 to
9b5a202
Compare
vezenovm
approved these changes
May 19, 2026
vezenovm
deleted the
nchamo/f-566-explore-macos-ci-coverage-for-the-full-dev-onboarding-path
branch
AztecBot
pushed a commit
that referenced
this pull request
May 21, 2026
## Summary - Adds `macos-latest` to the `aztec-cli-acceptance-test` workflow via `strategy.matrix` so the full dev onboarding test runs on both Ubuntu and macOS in parallel, with `fail-fast: false` so one OS failure doesn't cancel the other. - Splits Slack notifications into a downstream `notify` job (`needs: release-acceptance` + `always()`) so a single consolidated message fires after both matrix entries finish. - Moves all Node setup into `run-test.sh`: it now installs NVM if missing and `nvm install --lts` unconditionally, then `aztec-up`'s `install_node` can upgrade further via the same NVM if needed. This makes the runner self-contained and unblocks macOS, where the GitHub Actions image ships without NVM (the previous `setup-node` step put Node 22 in PATH but left `aztec-up` with no way to satisfy its `>=24.12.0` requirement). Fixes F-566
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #23449. |
AztecBot
added a commit
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-latestto theaztec-cli-acceptance-testworkflow viastrategy.matrixso the full dev onboarding test runs on both Ubuntu and macOS in parallel, withfail-fast: falseso one OS failure doesn't cancel the other.notifyjob (needs: release-acceptance+always()) so a single consolidated message fires after both matrix entries finish.run-test.sh: it now installs NVM if missing andnvm install --ltsunconditionally, thenaztec-up'sinstall_nodecan upgrade further via the same NVM if needed. This makes the runner self-contained and unblocks macOS, where the GitHub Actions image ships without NVM (the previoussetup-nodestep put Node 22 in PATH but leftaztec-upwith no way to satisfy its>=24.12.0requirement).Fixes F-566