fix: released contract artifact aztec version (forward port of #23470)#23500
Merged
benesjan merged 1 commit intoMay 24, 2026
Merged
Conversation
The v4.3.0 release shipped contract artifact JSONs with aztec_version: "dev" baked in, because release-image/Dockerfile copies pre-built artifacts from an earlier stage where REF_NAME isn't set (so stamp_aztec_version in noir-projects/noir-contracts/bootstrap.sh falls back to "dev"). Mirror the stdlib/package.json stamp pattern (75fd494) to re-stamp aztec_version in every artifact under accounts/, noir-contracts.js/, and noir-test-contracts.js/ at image-build time. Forward port of #23470 from backport-to-v4-next-staging. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
benesjan
force-pushed
the
bj/fix-release-image-stamp-artifacts-fp
branch
from
9556432 to
36b6d32
Compare
Contributor
Author
|
Merging this as I just verified the fix worked on v4-next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #23470 (originally merged to
backport-to-v4-next-stagingfor the v4 release line).Important
Do not merge until we get a green v4 nightly release.
Summary
The v4.3.0 release shipped contract artifact JSONs with
aztec_version: "dev"baked in, which caused ci-compat-e2e to fail because the artifact version did not match the expected tested version. The root cause is thatREF_NAMEis not reliably populated when the release artifacts are built, sostamp_aztec_versioninnoir-projects/noir-contracts/bootstrap.shwas falling back to"dev".The fix re-stamps the version at the point in the release process where the actual version is known:
ci3/release_prep_package_jsonnow stampsaztec_versionintoartifacts/*.jsonat npm-publish time using the authoritative$versionarg.release-image/Dockerfilenow re-stampsaztec_versioninto all shipped contract artifacts (accounts, noir-contracts.js, noir-test-contracts.js) using$VERSIONat image build time.noir-projects/noir-contracts/bootstrap.shis simplified to always stamp"dev"(renamed tostamp_dev_aztec_version) — the real version is now applied at publish time by whichever path owns it.The
stamp_dev_aztec_versionhelper preserves thecat/rmpattern from #23174 so artifact file permissions aren't clobbered.The
assertContractArtifactsVersion()bypass from the original PR is omitted here because v5 doesn't have the bad v4.3.0 artifact in its compat matrix.Verification (from the original PR)
DRY_RUN=1 ../../ci3/deploy_npm latest 5.1.0-testproduced artifacts withaztec_version: "5.1.0-test".aztec_versionmatches$VERSION.