Skip to content

fix(ci): skip aztec-cli notify job when acceptance test is skipped#23534

Merged
nchamo merged 1 commit into
merge-train/fairiesfrom
cb/4f2981433b0c
May 23, 2026
Merged

fix(ci): skip aztec-cli notify job when acceptance test is skipped#23534
nchamo merged 1 commit into
merge-train/fairiesfrom
cb/4f2981433b0c

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Summary

The notify job in .github/workflows/aztec-cli-acceptance-test.yml is currently gated on if: always() && github.event_name != 'workflow_dispatch'. That means it runs on every workflow_run event regardless of whether release-acceptance actually executed. When the upstream CI3 run on a v* nightly branch fails, release-acceptance is correctly skipped (its own if: requires workflow_run.conclusion == 'success'), but notify still spins up a runner, checks out the repo, finds that its two inner steps both gate on needs.release-acceptance.result == 'success' / 'failure' (neither matches 'skipped'), skips both, and exits with conclusion=success having posted nothing.

Example of the prior behavior: https://github.com/AztecProtocol/aztec-packages/actions/runs/26329465058 — the upstream v5.0.0-nightly.20260523 CI3 run failed, release-acceptance correctly skipped, but notify still ran and posted nothing.

This change replaces always() with (success() || failure()). Those are status-check functions evaluated against needs: and they explicitly do not match 'skipped' or 'cancelled', so notify is now also skipped when the test job didn't run — no runner allocated, no green "success" tick for a job that did nothing.

Behavior matrix for the new condition (release-acceptance.result):

  • successnotify runs, "Notify Slack on success" step fires
  • failurenotify runs, "Notify Slack and dispatch ClaudeBox on failure" step fires
  • skippednotify is skipped, no runner allocated
  • cancellednotify is skipped, no runner allocated

The asymmetry (job-level always() vs step-level result == 'success'/'failure') dates to the macOS-matrix split in #23309; the original workflow had the notify steps inside the test job gated on success()/failure(), which inherently never fired on skip.

Test plan

  • One-line YAML change; the workflow still parses and the existing pass/fail notification paths are unaffected.
  • Real validation needs the next CI3-on-v* event: a failing nightly should now show notify as skipped (not green-success); a successful nightly should still post the success message; an actual release-acceptance failure should still dispatch the failure notification and ClaudeBox.

Created by claudebox · group: slackbot

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 23, 2026
@nchamo nchamo marked this pull request as ready for review May 23, 2026 23:42
@nchamo nchamo requested a review from charlielye as a code owner May 23, 2026 23:42
@nchamo nchamo self-assigned this May 23, 2026
@nchamo nchamo enabled auto-merge (squash) May 23, 2026 23:42
@nchamo nchamo merged commit c47e668 into merge-train/fairies May 23, 2026
36 of 37 checks passed
@nchamo nchamo deleted the cb/4f2981433b0c branch May 23, 2026 23:51
@AztecBot
Copy link
Copy Markdown
Collaborator Author

✅ Successfully backported to backport-to-v4-next-staging #23535.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4-next claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants