fix(ci): skip aztec-cli notify job when acceptance test is skipped#23534
Merged
Conversation
nchamo
approved these changes
May 23, 2026
AztecBot
added a commit
that referenced
this pull request
May 24, 2026
Collaborator
Author
|
✅ Successfully backported to backport-to-v4-next-staging #23535. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
notifyjob in.github/workflows/aztec-cli-acceptance-test.ymlis currently gated onif: always() && github.event_name != 'workflow_dispatch'. That means it runs on everyworkflow_runevent regardless of whetherrelease-acceptanceactually executed. When the upstreamCI3run on av*nightly branch fails,release-acceptanceis correctly skipped (its ownif:requiresworkflow_run.conclusion == 'success'), butnotifystill spins up a runner, checks out the repo, finds that its two inner steps both gate onneeds.release-acceptance.result == 'success'/'failure'(neither matches'skipped'), skips both, and exits withconclusion=successhaving posted nothing.Example of the prior behavior: https://github.com/AztecProtocol/aztec-packages/actions/runs/26329465058 — the upstream
v5.0.0-nightly.20260523CI3 run failed,release-acceptancecorrectly skipped, butnotifystill ran and posted nothing.This change replaces
always()with(success() || failure()). Those are status-check functions evaluated againstneeds:and they explicitly do not match'skipped'or'cancelled', sonotifyis now also skipped when the test job didn't run — no runner allocated, no green "success" tick for a job that did nothing.Behavior matrix for the new condition (
release-acceptance.result):success→notifyruns, "Notify Slack on success" step firesfailure→notifyruns, "Notify Slack and dispatch ClaudeBox on failure" step firesskipped→notifyis skipped, no runner allocatedcancelled→notifyis skipped, no runner allocatedThe asymmetry (job-level
always()vs step-levelresult == 'success'/'failure') dates to the macOS-matrix split in #23309; the original workflow had the notify steps inside the test job gated onsuccess()/failure(), which inherently never fired on skip.Test plan
CI3-on-v*event: a failing nightly should now shownotifyas skipped (not green-success); a successful nightly should still post the success message; an actualrelease-acceptancefailure should still dispatch the failure notification and ClaudeBox.Created by claudebox · group:
slackbot