From f9627033f1258d30a52c213853d8f97657ccb7df Mon Sep 17 00:00:00 2001 From: Santiago Palladino Date: Tue, 5 Dec 2023 09:47:44 -0300 Subject: [PATCH] chore: Pin node version in docker base images and bump nvmrc (#3537) We were using a floating version of node in our base images, which means we didn't control when we updated the node version. Also, we were using an outdated version for local development, which didn't match the one used for the base images. This changeset bumps nvmrc to latest node (18.19.0) and pins down the version of all node base images across dockerfiles in the project. This PR was triggered by suddenly hitting [this error](https://github.com/TypeStrong/ts-node/issues/2094) in CI. --- acir_tests/Dockerfile.bb | 2 +- acir_tests/Dockerfile.bb.js | 2 +- acir_tests/Dockerfile.bb.sol | 2 +- ts/Dockerfile | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/acir_tests/Dockerfile.bb b/acir_tests/Dockerfile.bb index 000627d817..7e211d62ec 100644 --- a/acir_tests/Dockerfile.bb +++ b/acir_tests/Dockerfile.bb @@ -1,7 +1,7 @@ FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/barretenberg-x86_64-linux-clang-assert FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/noir-acir-tests as noir-acir-tests -FROM node:18-alpine +FROM node:18.19.0-alpine RUN apk update && apk add git bash curl jq coreutils COPY --from=0 /usr/src/barretenberg/cpp/build /usr/src/barretenberg/cpp/build COPY --from=noir-acir-tests /usr/src/noir/test_programs /usr/src/noir/test_programs diff --git a/acir_tests/Dockerfile.bb.js b/acir_tests/Dockerfile.bb.js index 1b86d6e953..248d14aeed 100644 --- a/acir_tests/Dockerfile.bb.js +++ b/acir_tests/Dockerfile.bb.js @@ -1,7 +1,7 @@ FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/bb.js FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/noir-acir-tests as noir-acir-tests -FROM node:18 +FROM node:18.19.0 COPY --from=0 /usr/src/barretenberg/ts /usr/src/barretenberg/ts COPY --from=noir-acir-tests /usr/src/noir/test_programs /usr/src/noir/test_programs RUN apt update && apt install -y lsof jq diff --git a/acir_tests/Dockerfile.bb.sol b/acir_tests/Dockerfile.bb.sol index 7840d0c2e4..40ffa07507 100644 --- a/acir_tests/Dockerfile.bb.sol +++ b/acir_tests/Dockerfile.bb.sol @@ -2,7 +2,7 @@ FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/barretenberg-x86_64-linux-clan FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/barretenberg-x86_64-linux-clang-sol FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/noir-acir-tests as noir-acir-tests -FROM node:18-alpine +FROM node:18.19.0-alpine RUN apk update && apk add git bash curl jq COPY --from=0 /usr/src/barretenberg/cpp/build /usr/src/barretenberg/cpp/build COPY --from=1 /usr/src/barretenberg/sol/src/ultra/BaseUltraVerifier.sol /usr/src/barretenberg/sol/src/ultra/BaseUltraVerifier.sol diff --git a/ts/Dockerfile b/ts/Dockerfile index 1edeb3c437..2d01fb8f76 100644 --- a/ts/Dockerfile +++ b/ts/Dockerfile @@ -1,6 +1,6 @@ FROM 278380418400.dkr.ecr.eu-west-2.amazonaws.com/barretenberg-wasm-linux-clang -FROM node:18-alpine +FROM node:18.19.0-alpine COPY --from=0 /usr/src/barretenberg /usr/src/barretenberg # Create a standalone container that can run bb.js (and tests).