add 2 examples and update readme #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zikalino
approved these changes
Dec 21, 2017
README.md
Outdated
| @@ -1,57 +1,30 @@ | |||
| # Project Name | |||
| # Ansible-playbooks | |||
|
|
|||
There was a problem hiding this comment.
I think we could just have "Ansible Playbooks for Azure" in title here
| hosts: localhost | ||
| connection: local | ||
| vars: | ||
| resource_group: demo |
There was a problem hiding this comment.
I think we could add comment here:
change variables below to customize your VM deployment
or something like this
There was a problem hiding this comment.
haha, i have added # at the beginning of the line, that's why so big ;-)
There was a problem hiding this comment.
Thank you for suggestion. Add comment for 2 playbook files.
| @@ -0,0 +1,61 @@ | |||
| --- | |||
There was a problem hiding this comment.
perhaps we should have comment here to describe what the playbook does in more details
|
@zikalino ready_for_review |
zikalino
approved these changes
Dec 22, 2017
|
#sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
No
Pull Request Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x ] Documentation content changes
[ ] Other... Please describe: