Post Deployment Fix for Nginx IC traffic policy #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you very much @naioja for logging the issue & this contribution! We use these variables for nginx but also contour, so I will test to ensure the contour option still works today, then approve. Thank you for your 1st contribution. |
Gordonby
changed the title
|
Like you previously mentioned I see that at line we are using the same variable for Contur.Looking at the Contur official documentation the same spelling is used with capital L and C for Local and Cluster : https://tanzu.vmware.com/developer/guides/service-routing-contour-refarch/#avoiding-unnecessary-network-hops |
khowling
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes syntax of value ingress_externalTrafficPolicy for nginx IC.
closes #415
PR Checklist