Makefile: Do not export CGO_CFLAGS if os is Darwin (macos) #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troy0820
requested review from
ehashman,
jim-minter,
mjudeikis and
olga-mir
as code owners
troy0820
force-pushed
the
fix/makefile
branch
3 times, most recently
from
a107d5a
to
3082d1d
Compare
|
I have a feeling (not a verified feeling :)) that it is just a version skew. Maybe we can just install a matching version of gpgme and update macOS dev env doc explaining how to do it? |
m1kola
reviewed
Oct 20, 2020
|
|
||
| export CGO_CFLAGS=-Dgpgme_off_t=off_t | ||
| ifndef CGO_CFLAGS | ||
| ifneq ("${OS}", "Darwin") |
There was a problem hiding this comment.
It should probably be something like this
UNAME_S := $(shell uname -s)
ifndef CGO_CFLAGS
ifneq ("$(shell uname -s)", "Darwin")
CGO_CFLAGS=-Dgpgme_off_t=off_t;
endif
endifBut I don't like it: I would like to avoid having a special case if possible. See #1082 (comment)
|
E2E fails with missing flakgs. Back to drawing board @troy0820 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Issue 301
Fixes #301
What this PR does / why we need it:
When trying to use make on macos x, it exports the
CGO_CFLAGSand disrupts the process with an errorTest plan for issue:
make generate, make test-go all worked with success on macos x
Is there any documentation that needs to be updated for this PR?
NONE