-
Notifications
You must be signed in to change notification settings - Fork 4
Set User Agent and Correlation Context for requests #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8a0dde to
23d5efe
Compare
23d5efe to
6aba2ca
Compare
avanigupta
reviewed
Sep 18, 2023
avanigupta
reviewed
Sep 18, 2023
avanigupta
reviewed
Sep 18, 2023
avanigupta
reviewed
Sep 18, 2023
avanigupta
reviewed
Sep 18, 2023
avanigupta
reviewed
Sep 18, 2023
avanigupta
reviewed
Sep 20, 2023
avanigupta
reviewed
Sep 20, 2023
avanigupta
reviewed
Sep 20, 2023
avanigupta
reviewed
Sep 20, 2023
avanigupta
reviewed
Sep 21, 2023
avanigupta
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following .NET provider, collecting almost the same properties (if applied) in Correlation-Context header.
Note:
We also want to distinguish runtimes where request is sent from (e.g. NodeJS, React Native, Web, Web Worker...). Maybe also use
Hostfor that. Since it's not determined yet, I would prefer to do it in a separate PR later.