Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: auto update and update node #1060

Merged
merged 5 commits into from
Feb 12, 2018
Merged

Fix: auto update and update node #1060

merged 5 commits into from
Feb 12, 2018

Conversation

timotheeguerin
Copy link
Member

Auto update should be called in setImmediate

@timotheeguerin timotheeguerin changed the title Fix: auto update Fix: auto update and update node Feb 9, 2018
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #1060 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   53.59%   53.59%   -0.01%     
==========================================
  Files         848      848              
  Lines       20208    20210       +2     
  Branches     2276     2276              
==========================================
  Hits        10831    10831              
- Misses       9377     9379       +2
Impacted Files Coverage Δ
app/services/electron/remote.service.ts 10% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809154e...b31dd61. Read the comment docs.

@timotheeguerin timotheeguerin merged commit a39441b into master Feb 12, 2018
@timotheeguerin timotheeguerin deleted the fix/auto-update branch February 25, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant