Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March a11y Bug Fixes #2472

Merged
merged 6 commits into from
Apr 21, 2022
Merged

March a11y Bug Fixes #2472

merged 6 commits into from
Apr 21, 2022

Conversation

cRui861
Copy link
Member

@cRui861 cRui861 commented Mar 10, 2022

  • Fix luminosity contrast ratio for "The node the task ran on doesn't exist anymore or is in an invalid state" warning for tasks by increasing background color:
    image

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2472 (c948303) into master (3bd43c7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2472   +/-   ##
=======================================
  Coverage   64.98%   64.99%           
=======================================
  Files         914      914           
  Lines       26345    26348    +3     
  Branches     5178     5179    +1     
=======================================
+ Hits        17121    17124    +3     
  Misses       9224     9224           
Impacted Files Coverage Δ
...sk/ui/datetime-picker/datetime-picker.component.ts 96.07% <ø> (ø)
...elect/select-dropdown/select-dropdown.component.ts 96.82% <100.00%> (+0.05%) ⬆️
src/@batch-flask/ui/select/select.component.ts 81.33% <100.00%> (+0.13%) ⬆️
src/app/utils/pool-utils.ts 83.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd43c7...c948303. Read the comment docs.

@dpwatrous
Copy link
Member

dpwatrous commented Mar 16, 2022

AB#291 - added a higher contrast border to code sample inputs:

Screen Shot 2022-03-16 at 12 12 05 PM

@cRui861
Copy link
Member Author

cRui861 commented Apr 18, 2022

/azp run [BatchExplorer - CI]

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@cRui861
Copy link
Member Author

cRui861 commented Apr 18, 2022

/azp run BatchExplorer - CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gingi gingi marked this pull request as ready for review April 21, 2022 21:31
@cRui861 cRui861 merged commit 96577a1 into master Apr 21, 2022
@cRui861 cRui861 deleted the bugfix/a11y-mar-22 branch April 21, 2022 23:15
gingi pushed a commit that referenced this pull request Jul 1, 2022
gingi pushed a commit that referenced this pull request Jul 1, 2022
gingi pushed a commit that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants