Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Bug Fixes (461, 573, 604, 605, 778) #2710

Merged
merged 5 commits into from
May 4, 2023

Conversation

mhdahman
Copy link
Contributor

@mhdahman mhdahman commented Apr 19, 2023

Resolves

  • [Bug 461] [Keyboard Navigation -Batch Explorer - 3DS Max] Tooltip content is not displayed on "3DS Max" button while navigating with keyboard.
  • [Bug 604] [Programmatic Access-Batch Explorer- Gallery-Local template library] On the Set local folders containing your templates window, an incorrect structure is defined for the friendly name control.
  • [Bug 605] [Screen Reader-Batch Explorer- Gallery-Local template library] On the Set local folders containing your templates window, the label (friendly name) is not associated with the control.
  • [Bug 778] [Visual Requirement- Batch Explorer- Terminate button]: Tooltip is not visible on keyboard focus for terminate button.
  • [Bug 573] [Programmatic Access-Batch Explorer-No favorite item pinned] Name is not defined for the control available inside the 1 favorite items pinned button.

Notable Changes

Tooltips on bl-buttons

This PR replaces native user-agent tooltips with mattooltips for all instances of bl-button to add proper keyboard support.

Screenshot 2023-04-26 at 3 40 07 PM

This also removes the label attributes on the button to prevent double tooltips from showing up now that tooltips are rendered by mattooltips:

Screenshot 2023-04-19 at 2 04 18 PM

Although the label attribute is removed, mattooltip still applies aria-label with the same value as the label attribute so screen readers should still be able to announce the intended label.

Screenshot 2023-04-26 at 3 44 15 PM

@mhdahman mhdahman force-pushed the mhdahman/a11y-bugfixes branch 3 times, most recently from 9b11dff to 06d0fa7 Compare April 26, 2023 22:18
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2710 (0dc197d) into master (6151cc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0dc197d differs from pull request most recent head 6686bdf. Consider uploading reports for the commit 6686bdf to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2710   +/-   ##
=======================================
  Coverage   65.08%   65.09%           
=======================================
  Files         916      916           
  Lines       26490    26494    +4     
  Branches     5240     5240           
=======================================
+ Hits        17242    17246    +4     
  Misses       9248     9248           
Impacted Files Coverage Δ
src/@batch-flask/ui/buttons/button.component.ts 100.00% <100.00%> (ø)
...-flask/ui/buttons/clickable/clickable.component.ts 97.95% <100.00%> (+0.04%) ⬆️
...ui/form/editable-table/editable-table.component.ts 98.82% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6151cc5...6686bdf. Read the comment docs.

@mhdahman mhdahman changed the title Accessibility Bug Fixes (461, 604, 605, 778) Accessibility Bug Fixes (461, 573, 604, 605, 778) Apr 26, 2023
@mhdahman mhdahman marked this pull request as ready for review April 26, 2023 23:05
gingi
gingi previously approved these changes May 1, 2023
src/@batch-flask/ui/buttons/button.scss Outdated Show resolved Hide resolved
@mhdahman mhdahman merged commit 10bf560 into master May 4, 2023
@mhdahman mhdahman deleted the mhdahman/a11y-bugfixes branch May 4, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants