-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility Bug Fixes (461, 573, 604, 605, 778) #2710
Conversation
9b11dff
to
06d0fa7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
=======================================
Coverage 65.08% 65.09%
=======================================
Files 916 916
Lines 26490 26494 +4
Branches 5240 5240
=======================================
+ Hits 17242 17246 +4
Misses 9248 9248
Continue to review full report in Codecov by Sentry.
|
a665583
to
1db226a
Compare
1db226a
to
22c3094
Compare
22c3094
to
a182ce7
Compare
a182ce7
to
6686bdf
Compare
Resolves
Notable Changes
Tooltips on
bl-buttons
This PR replaces native user-agent tooltips with mattooltips for all instances of
bl-button
to add proper keyboard support.This also removes the
label
attributes on the button to prevent double tooltips from showing up now that tooltips are rendered bymattooltips
:Although the
label
attribute is removed,mattooltip
still appliesaria-label
with the same value as the label attribute so screen readers should still be able to announce the intended label.