-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification API for shared libraries #2778
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2778 +/- ##
==========================================
- Coverage 66.47% 66.45% -0.02%
==========================================
Files 1229 1232 +3
Lines 33744 33835 +91
Branches 6158 6160 +2
==========================================
+ Hits 22431 22485 +54
- Misses 11179 11216 +37
Partials 134 134
Continue to review full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here. |
Rena, can you provide a screenshot or two of the demo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great, but I think renaming "Notification" to "Notifier" will avoid some confusion in the future.
8105653
to
1390704
Compare
* WIP Notification fakes * Move notification files over to bonito-core * Fix paths * Update naming from notification to notifier
Includes a notification demo in the playground for Portal and a mock notifier (for Batch Explorer).
Screenshots from the Portal playground demo:
Screenshots from web Playground demo