-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared library refactoring #2781
Conversation
73a674e
to
6be36e1
Compare
6be36e1
to
314d94c
Compare
314d94c
to
b7161fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
- Coverage 66.62% 66.58% -0.04%
==========================================
Files 1209 1225 +16
Lines 33751 33815 +64
Branches 6219 6225 +6
==========================================
+ Hits 22486 22517 +31
- Misses 11126 11160 +34
+ Partials 139 138 -1
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
b75db73
to
2ae590d
Compare
These packages are intended to act as a Batch-agnostic layer for building Azure Portal-compatible UIs. This also moves much of the functionality of the ui-service package into bonito-core (specifically the parts that aren't Batch-specific)
2ae590d
to
0b523d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run loc:build
is now failing due to invalid paths in LocProject.json
. The copy-translations
script also needs to be adjusted. Will add fixes for these
* Add .DS_Store to .gitignore * Factor out bonito-core and bonito-ui These packages are intended to act as a Batch-agnostic layer for building Azure Portal-compatible UIs. This also moves much of the functionality of the ui-service package into bonito-core (specifically the parts that aren't Batch-specific) * Make `bux link` handle missing packages in node_modules --------- Co-authored-by: Sanjana Kapur <sanjanakapur@microsoft.com>
This PR factors out common functionality which is not Batch-specific into two new packages: @azure/bonito-core and @azure/bonito-ui.