Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate form setValues to subForm #2801

Merged
merged 4 commits into from
Sep 14, 2023
Merged

populate form setValues to subForm #2801

merged 4 commits into from
Sep 14, 2023

Conversation

wanghoppe
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2801 (0c68450) into main (40b3354) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0c68450 differs from pull request most recent head 2f55362. Consider uploading reports for the commit 2f55362 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2801      +/-   ##
==========================================
+ Coverage   66.47%   66.48%   +0.01%     
==========================================
  Files        1230     1230              
  Lines       33813    33816       +3     
  Branches     6161     6113      -48     
==========================================
+ Hits        22476    22483       +7     
+ Misses      11203    11199       -4     
  Partials      134      134              
Files Changed Coverage Δ
...ackages/bonito-core/src/form/internal/form-impl.ts 81.81% <100.00%> (+1.17%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b3354...2f55362. Read the comment docs.

@wanghoppe wanghoppe enabled auto-merge (squash) September 14, 2023 14:26
@wanghoppe wanghoppe merged commit 02e6dff into main Sep 14, 2023
6 checks passed
@wanghoppe wanghoppe deleted the hoppe/subform-setvalue branch September 14, 2023 14:58
gingi pushed a commit that referenced this pull request Nov 9, 2023
* fix: npm run watch on packages

* populate setValues to subForm

* back to deep copy

---------

Co-authored-by: hoppe <hoppewang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants