From ba6327aeadafe3944799e4f0eafc9b28eb70f12a Mon Sep 17 00:00:00 2001 From: Riley Evans Date: Thu, 21 Mar 2024 16:15:18 -0500 Subject: [PATCH] fix(Designer): Secure string workflow parameters now pass validation (#4408) * Fixed secure string wf parameters validation * Slight rename * PR comment fix --- .../src/lib/core/actions/bjsworkflow/serializer.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts b/libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts index 454cb6bd9fd..5000dccd74b 100644 --- a/libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts +++ b/libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts @@ -220,7 +220,11 @@ const getWorkflowParameters = ( delete parameterDefinition['name']; delete parameterDefinition['isEditable']; - parameterDefinition.value = equals(parameterDefinition.type, UIConstants.WORKFLOW_PARAMETER_TYPE.STRING) + const isStringParameter = + equals(parameterDefinition.type, UIConstants.WORKFLOW_PARAMETER_TYPE.STRING) || + equals(parameterDefinition.type, UIConstants.WORKFLOW_PARAMETER_TYPE.SECURE_STRING); + + parameterDefinition.value = isStringParameter ? value : value === '' ? undefined @@ -228,7 +232,7 @@ const getWorkflowParameters = ( ? value : JSON.parse(value); - parameterDefinition.defaultValue = equals(parameterDefinition.type, UIConstants.WORKFLOW_PARAMETER_TYPE.STRING) + parameterDefinition.defaultValue = isStringParameter ? defaultValue : defaultValue === '' ? undefined