Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lafeat: Workflow is clamped to remain in view #1349

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Conversation

rllyy97
Copy link
Contributor

@rllyy97 rllyy97 commented Nov 23, 2022

Main Changes

  • Trying to translate the workflow off the viewport is now blocked
    • This is dynamic and updates the clamps on adding/removing nodes, expanding graphs, zooming, etc.
    • It will let the workflow get hidden all the way up to the last whole node (by default node sizes)
      • In the example since it is only one column you aren't able to drag any of it off the left and right
  • I put this behind a variable in state in case we want to test with/without it

Hopefully the main outcome is that users will be stranded in no-man's-land much less often. If they make a change and the workflow updates, they will (mostly) always have some part of their workflow on the screen, where as before you would have to drag around until you found it

drag clamping

// Note: When expanding/collapsing graph nodes, it doesn't update the bounds until the viewport updates

@rllyy97 rllyy97 changed the title Riley/pan clamp lafeat: Workflow is clamped to remain in view Nov 23, 2022
@rllyy97 rllyy97 marked this pull request as ready for review November 28, 2022 19:25
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-pebble-0e11de71e-1349.westus2.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-pebble-0e11de71e-1349.westus2.1.azurestaticapps.net

@rllyy97 rllyy97 enabled auto-merge (squash) December 2, 2022 23:14
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://purple-pebble-0e11de71e-1349.westus2.1.azurestaticapps.net

@rllyy97 rllyy97 merged commit ce4adb6 into main Dec 2, 2022
@hartra344 hartra344 deleted the riley/pan-clamp branch December 5, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants