Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.FrontDoorWAF.Exclusions reports exclusions when none is specified #1751

Closed
BernieWhite opened this issue Oct 4, 2022 · 0 comments · Fixed by #1754
Closed

Azure.FrontDoorWAF.Exclusions reports exclusions when none is specified #1751

BernieWhite opened this issue Oct 4, 2022 · 0 comments · Fixed by #1754
Assignees
@BernieWhite
Labels
bug Something isn't working rule: front-door Rule for Azure Front Door
Milestone
v1.20.0

Comments

@BernieWhite
Copy link
Collaborator

BernieWhite commented Oct 4, 2022 •
edited

Description of the issue

If the exclusions property of a managedRuleSets does not exist, Azure.FrontDoorWAF.Exclusions returns a false positive.

Also applies to Azure.AppGwWAF.Exclusions.

Expected behaviour

The rule should pass if exclusions is not set or empty.

Error output

Path Properties.managedRules.managedRuleSets[0].exclusions: The field 'Properties.managedRules.managedRuleSets[0].exclusions' does not exist.

Module in use and version:

  • Module: PSRule.Rules.Azure
  • Version: 1.20.0-B0223
@BernieWhite BernieWhite added bug Something isn't working rule: front-door Rule for Azure Front Door labels Oct 4, 2022
@BernieWhite BernieWhite added this to the v1.20.0 milestone Oct 4, 2022
@BernieWhite BernieWhite changed the title Azure.FrontDoorWAF.Exclusions reports exclusions when none a specified Azure.FrontDoorWAF.Exclusions reports exclusions when none is specified Oct 4, 2022
@BernieWhite BernieWhite self-assigned this Oct 4, 2022
BernieWhite added a commit to BernieWhite/PSRule.Rules.Azure that referenced this issue Oct 4, 2022
@BernieWhite
Fixes Azure.FrontDoorWAF.Exclusions Azure#1751
51e3116
BernieWhite added a commit to BernieWhite/PSRule.Rules.Azure that referenced this issue Oct 4, 2022
@BernieWhite
Fixes Azure.FrontDoorWAF.Exclusions Azure#1751
43abee4
@BernieWhite BernieWhite mentioned this issue Oct 4, 2022
Merged
8 tasks
BernieWhite added a commit that referenced this issue Oct 4, 2022
@BernieWhite
Fixes Azure.FrontDoorWAF.Exclusions #1751 (#1754)
12b5040
This was referenced Oct 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
bug Something isn't working rule: front-door Rule for Azure Front Door
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging a pull request may close this issue.

Fixes Azure.FrontDoorWAF.Exclusions #1751 BernieWhite/PSRule.Rules.Azure
1 participant
@BernieWhite