Skip to content

Conversation

@hannahwestra25
Copy link
Contributor

Description

image

  1. Change all variables that are Optional to equal None
  2. If a variable is marked as Optional but has a default value of something other than None, remove the optional keyword
  3. If a variable has a default value of None, mark it as Optional

image
https://peps.python.org/pep-0484/

This shouldn't be a breaking change just a shift towards being more explicit

Tests and Documentation

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's double check all the docstrings to make sure they're in sync. I found a bunch that weren't.

Copy link
Contributor

@bashirpartovi bashirpartovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks great, just a few comments

@hannahwestra25 hannahwestra25 merged commit 4225953 into Azure:main Jun 2, 2025
19 checks passed
KutalVolkan pushed a commit to KutalVolkan/PyRIT that referenced this pull request Jun 4, 2025
migdaepp pushed a commit to migdaepp/PyRIT-anecdoctor that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants