-
Notifications
You must be signed in to change notification settings - Fork 591
[MAINT] Explicit Optional Parameters #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hannahwestra25
merged 10 commits into
Azure:main
from
hannahwestra25:hawestra/optionalRefactor
Jun 2, 2025
Merged
[MAINT] Explicit Optional Parameters #927
hannahwestra25
merged 10 commits into
Azure:main
from
hannahwestra25:hawestra/optionalRefactor
Jun 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
May 23, 2025
hannahwestra25
commented
May 27, 2025
romanlutz
reviewed
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's double check all the docstrings to make sure they're in sync. I found a bunch that weren't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks great, just a few comments
romanlutz
approved these changes
May 29, 2025
KutalVolkan
pushed a commit
to KutalVolkan/PyRIT
that referenced
this pull request
Jun 4, 2025
migdaepp
pushed a commit
to migdaepp/PyRIT-anecdoctor
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://peps.python.org/pep-0484/
This shouldn't be a breaking change just a shift towards being more explicit
Tests and Documentation