FIX fixing pre-commit windows job to use cache #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we hardcoding to 3.11? |
@romanlutz it has always been like that, we are running pre-commit only for 1 version, python 3.11 |
Right, but if you want to change it at some point you have to make a bunch of changes now. Previously it was just set once in the matrix |
@romanlutz , ahh I see what you mean, fixed! |
romanlutz
approved these changes
Jun 20, 2025
Sarayu-code
pushed a commit
to Sarayu-code/PyRIT
that referenced
this pull request
Jul 11, 2025
Co-authored-by: Bashir Partovi <bpartovi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit job for windows currently is not using cache because it is using the default powershell and the env variable doesn't translate well. I am separating the precommit jobs to define that better.