This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
fix: update the node name label as part of AzureAssignedIdentity update
#1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
update-metadata-label
branch
from
9d3c027
to
2d6e136
Compare
aramase
changed the title
AzureAssignedIdentity update
aramase
force-pushed
the
update-metadata-label
branch
from
2d6e136
to
0eb2f41
Compare
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
force-pushed
the
update-metadata-label
branch
from
0eb2f41
to
89e5000
Compare
3 tasks
chewong
approved these changes
Sep 13, 2021
statbit
pushed a commit
to adobe-platform/aad-pod-identity
that referenced
this pull request
Sep 30, 2021
…te (Azure#1161) Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com
Reason for Change:
In case of stateful sets, the pod with the same name could move from one node to another still bound to the same
AzureIdentity. Currently in such scenarios, thenodenamelabel in metadata forAzureAssignedIdentityisn't updated to reflect the node change. This will cause token request to fail as NMI has filtered watch based on nodename.We need to use the old object metadata because resourceVersion needs to be set as part of update. This PR uses the existing object metadata and updates just the labels to latest.
Requirements
make precommitIssue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: