Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

List CRDs via cache and avoid extra work on pod update #232

Merged
merged 2 commits into from Jun 7, 2019

Conversation

kkmsft
Copy link
Contributor

@kkmsft kkmsft commented Jun 3, 2019

Two main items:
- Utilize the client cache for listing of CRDs
- Avoids going to API Server for every list call.
- Resolve the part of #182 related to the API Server calls.
- Avoid calling sync loop at every pod update. Only call where there is a change in scheduled node name.

Copy link
Contributor

@khenidak khenidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, can be as a follow up

/LGTM

BindingWatcher cache.SharedInformer
IDListWatch *cache.ListWatch
IdWatcher cache.SharedInformer
AssignedIDListWatch *cache.ListWatch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of ..Watch gives the impression that they are all the same type which the are not. Can we use a different naming for informers vs watchers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @khenidak.

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

	- Utilize the client cache for listing of CRDs
		- Avoids going to API Server for every list call.
		- Resolve the part of Azure#182 related to the API Server calls.
	- Avoid calling sync loop at every pod update. Only call where there is a change in scheduled node name.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants