New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install azure-vnet CNI plugin on K8S Windows agents #1505

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@ofiliz
Contributor

ofiliz commented Sep 27, 2017

What this PR does / why we need it:

This PR adds the logic to download, install and configure Azure VNET CNI plugins on Kubernetes Windows nodes. It brings Windows nodes to CNI-networking parity with Linux nodes in Kubernetes.

It also adds support for the "maxPods" kubelet parameter on Windows nodes.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1504

Special notes for your reviewer:
This PR updates kuberneteswindowssetup.ps1 (runs on Windows nodes first boot) with the same logic in kubernetesmastercustomscript.sh (runs on Linux nodes first boot).

I am marking the PR "do-not-merge" for now, because

  1. This PR requires #1480 to be merged first.
  2. Azure VNET CNI plugin requires Windows Server 2016 RS3 release, which is not yet available as a VM image in Azure. Windows team may also require some changes on top of this PR to enable full functionality.

Release note:

@anhowe, @lachie83, @nisheeth-ms, @sharmasushant, @tamilmani1989, @dineshgovindasamy

fixes #1504.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 27, 2017

CLA assistant check
All CLA requirements met.

msftclas commented Sep 27, 2017

CLA assistant check
All CLA requirements met.

Show outdated Hide outdated parts/kuberneteswindowssetup.ps1 Outdated
@ofiliz

This comment has been minimized.

Show comment
Hide comment
@ofiliz

ofiliz Sep 29, 2017

Contributor

@JiangtianLi Please mark this PR with "do-not-merge". It should not be merged until Windows team can test it with RS3 builds and make any necessary modifications in kuberneteswindowssetup.ps1.

Contributor

ofiliz commented Sep 29, 2017

@JiangtianLi Please mark this PR with "do-not-merge". It should not be merged until Windows team can test it with RS3 builds and make any necessary modifications in kuberneteswindowssetup.ps1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment