Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jumpbox custom vnet missing variables #2477

Merged
merged 3 commits into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@CecileRobertMichon
Copy link
Member

CecileRobertMichon commented Mar 15, 2018

What this PR does / why we need it: private cluster jumpbox is not compatible with custom vnets because the vm depends on the vnetID. Remove this dependency for clusters w/ custom vnets. The vmSizesMap is missing when the cluster does not have storage accounts so add it for deployments with a jumpbox. Thanks @stefanstranger for reporting the issue!

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2474

Special notes for your reviewer:

Release note:

CecileRobertMichon added some commits Mar 15, 2018

sizemaps for jumpbox managed disks
add sizesmap for jumpbox managed disks with no storage accounts
@jackfrancis
Copy link
Member

jackfrancis left a comment

lgtm

@CecileRobertMichon CecileRobertMichon merged commit 9b7dabc into Azure:master Mar 15, 2018

10 of 13 checks passed

ci/circleci: k8s-windows-1.7-release-e2e Your tests failed on CircleCI
Details
ci/circleci: k8s-windows-1.8-release-e2e Your tests failed on CircleCI
Details
ci/circleci: k8s-windows-1.9-release-e2e Your tests failed on CircleCI
Details
ci/circleci: build_and_test_pr/pr-e2e-hold Your job was approved on CircleCI!
Details
ci/circleci: dcos-e2e Your tests passed on CircleCI!
Details
ci/circleci: k8s-1.10-beta.2-release-e2e Your tests passed on CircleCI!
Details
ci/circleci: k8s-1.7-release-e2e Your tests passed on CircleCI!
Details
ci/circleci: k8s-1.8-release-e2e Your tests passed on CircleCI!
Details
ci/circleci: k8s-1.9-release-e2e Your tests passed on CircleCI!
Details
ci/circleci: swarm-e2e Your tests passed on CircleCI!
Details
ci/circleci: swarmmode-e2e Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details

@wafflebot wafflebot bot removed the in progress label Mar 15, 2018

tesharp added a commit to tesharp/acs-engine that referenced this pull request Mar 16, 2018

fix jumpbox custom vnet missing variables (Azure#2477)
* remove vnetID dependency for custom vnets

* forgot not

* sizemaps for jumpbox managed disks

add sizesmap for jumpbox managed disks with no storage accounts

@CecileRobertMichon CecileRobertMichon deleted the CecileRobertMichon:jumpbox-custom-vnet-bug branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.