Layer ADD source-code prior to make bootstrap layer in Dockerfile
#3767
Conversation
|
/assign @jackfrancis |
|
/assign @tariq1890 |
Dockerfile
Outdated
| @@ -27,7 +27,7 @@ RUN git clone https://github.com/akesterson/shunit.git /tmp/shunit \ | |||
| WORKDIR /gopath/src/github.com/Azure/acs-engine | |||
|
|
|||
| # Cache vendor layer | |||
| ADD Makefile test.mk versioning.mk Gopkg.toml Gopkg.lock /gopath/src/github.com/Azure/acs-engine/ | |||
| ADD Makefile test.mk versioning.mk Gopkg.toml Gopkg.lock . /gopath/src/github.com/Azure/acs-engine/ | |||
There was a problem hiding this comment.
Let's add packer.mk instead of the period. Adding the entire directory along with specific files seems inconsistent.
There was a problem hiding this comment.
I agree. I think it would be an even better idea to add the entire directory, which we do anyway, instead of individual files.
Just adding packer.mk to the list of files logs messages like
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
|
@ashish-amarnath Thanks for PR :). Added a review comment. |
ashish-amarnath
force-pushed
the
fix-dockerfile-layering
branch
from
fe0e60e
to
675e826
Compare
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
======================================
Coverage 55.4% 55.4%
======================================
Files 108 108
Lines 16102 16102
======================================
Hits 8921 8921
Misses 6417 6417
Partials 764 764 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ashish-amarnath, tariq1890 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Currently, building ACS Engine from Source fails. This PR fixes that.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3766Special notes for your reviewer:
If applicable:
Release note: