Update hyperkube command in manifests for k8s components. #1279
Conversation
In k8s 1.15 this PR : kubernetes/kubernetes#76953 removed aliases for k8s binaries in hyperkube ( i.e proxy alias for kube-proxy ). This PR changes the commands in all manifests that invoke hyperkube to use the full name of the binaries.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adelina-t If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @PatrickLang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is great @adelina-t, thank you for being proactive!
There are some places in the docs (and in code) where we refer to these components by the short names. Is worth changing the docs references as well for consistency? Not in this PR necessarily, just asking.
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Could you
Otherwise this change won't show up in our CHANGELOG when we do a release. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 74.76% 74.76%
=======================================
Files 128 128
Lines 18333 18333
=======================================
Hits 13706 13706
Misses 3836 3836
Partials 791 791 |
Ditto, thanks @adelina-t! (fixed the commit message via squash commit) |
In k8s 1.15 this PR : kubernetes/kubernetes#76953
removed aliases for k8s binaries in hyperkube ( i.e proxy alias for kube-proxy ).
This PR changes the commands in all manifests that invoke hyperkube
to use the full name of the binaries.
Reason for Change:
PR kubernetes/kubernetes#76953 in kubernetes/kubernetes removed aliases for hyperkube binaries ( apiserver, proxy etc. ), thus the binaries have to be invoked by their full name ( kube-apiserver, kube-proxy etc. ).
This issue has been observed in upstream windows testing for k8s ( https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master ).
NOTE: