Navigation Menu

Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Update hyperkube command in manifests for k8s components. #1279

Merged
merged 1 commit into from May 10, 2019

Conversation

adelina-t
Copy link
Contributor

In k8s 1.15 this PR : kubernetes/kubernetes#76953
removed aliases for k8s binaries in hyperkube ( i.e proxy alias for kube-proxy ).

This PR changes the commands in all manifests that invoke hyperkube
to use the full name of the binaries.

Reason for Change:

PR kubernetes/kubernetes#76953 in kubernetes/kubernetes removed aliases for hyperkube binaries ( apiserver, proxy etc. ), thus the binaries have to be invoked by their full name ( kube-apiserver, kube-proxy etc. ).

This issue has been observed in upstream windows testing for k8s ( https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master ).

NOTE:

  • It does not affect aks-engine as it is now, as it only supports k8s 1.15.0-alpha.3 ( Change merged after this ) however it may pose a problem in future releases.
  • the full binary name, kube- , is supported in all k8s versions thus there shouldn't be any backwards compatibility issues.

In k8s 1.15 this PR : kubernetes/kubernetes#76953
removed aliases for k8s binaries in hyperkube ( i.e proxy alias for kube-proxy ).

This PR changes the commands in all manifests that invoke hyperkube
to use the full name of the binaries.
@acs-bot acs-bot added the size/S label May 10, 2019
@acs-bot
Copy link

acs-bot commented May 10, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adelina-t
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cecilerobertmichon

If they are not already assigned, you can assign the PR to them by writing /assign @cecilerobertmichon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adelina-t
Copy link
Contributor Author

/cc @PatrickLang

@acs-bot acs-bot requested a review from PatrickLang May 10, 2019 09:30
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This is great @adelina-t, thank you for being proactive!

There are some places in the docs (and in code) where we refer to these components by the short names. Is worth changing the docs references as well for consistency? Not in this PR necessarily, just asking.

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma
Copy link
Member

Could you git commit --amend the commit message so it's something like:

fix: update short hyperkube commands in manifests for k8s components

Otherwise this change won't show up in our CHANGELOG when we do a release. Thanks!

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1279 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1279   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files         128      128           
  Lines       18333    18333           
=======================================
  Hits        13706    13706           
  Misses       3836     3836           
  Partials      791      791

@jackfrancis jackfrancis merged commit c02f7de into Azure:master May 10, 2019
@jackfrancis
Copy link
Member

Ditto, thanks @adelina-t! (fixed the commit message via squash commit)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants