Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "allow-privileged" in kubelet 1.15.0 #1369

Merged
merged 2 commits into from May 29, 2019

Conversation

@andyzhangx
Copy link
Contributor

commented May 28, 2019

Reason for Change:

This PR remove --allow-privileged in kubelet config from k8s v1.15.0, since --allow-privileged is removed in this k8s upstream PR: kubernetes/kubernetes#77820

Issue Fixed:

Fixes#1368

Requirements:

Notes:

@acs-bot acs-bot added the size/XS label May 28, 2019
@andyzhangx

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

/azp run pr-e2e

@azure-pipelines

This comment has been minimized.

Copy link

commented May 28, 2019

Azure Pipelines successfully started running 1 pipeline(s).
@andyzhangx andyzhangx requested a review from jackfrancis May 28, 2019
@andyzhangx

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

@codecov

This comment has been minimized.

Copy link

commented May 28, 2019

Codecov Report

Merging #1369 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1369      +/-   ##
=========================================
+ Coverage    75.5%   75.5%   +<.01%     
=========================================
  Files         128     128              
  Lines       18141   18144       +3     
=========================================
+ Hits        13697   13700       +3     
  Misses       3641    3641              
  Partials      803     803
@jackfrancis jackfrancis added this to In progress in backlog May 28, 2019
fix comments
@andyzhangx andyzhangx force-pushed the andyzhangx:remove-allow-privileged branch from b39a74b to 7947440 May 29, 2019
@andyzhangx

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

/azp run pr-e2e
sth wrong with github...

@azure-pipelines

This comment has been minimized.

Copy link

commented May 29, 2019

No pipelines are associated with this pull request.
Copy link
Member

left a comment

/lgtm

@acs-bot acs-bot added the lgtm label May 29, 2019
@mboersma mboersma referenced this pull request May 29, 2019
2 of 5 tasks complete
@mboersma

This comment has been minimized.

Copy link
Member

commented May 29, 2019

We should add a test case for this to defaults-kubelet_test.go.

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@andyzhangx Could you add a unit test for this?

@mboersma Could you help to cut a release after this gets merged?

@acs-bot acs-bot added size/M and removed lgtm size/XS labels May 29, 2019
@mboersma

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@feiskyer @andyzhangx I added a unit test just now that should cover the flag removal. I'll ask the @Azure/aks-engine team about a release.

Copy link
Member

left a comment

/lgtm

backlog automation moved this from In progress to Under Review May 29, 2019
@acs-bot acs-bot added the lgtm label May 29, 2019
@acs-bot

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, CecileRobertMichon, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot added the approved label May 29, 2019
@CecileRobertMichon

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@feiskyer why is this needed in a patch release? 1.15 is still in pre-release and -beta.1 support wasn't released yet.

@acs-bot acs-bot merged commit ff33935 into Azure:master May 29, 2019
18 checks passed
18 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 75.5%)
Details
codecov/project 75.5% (+<.01%) compared to c6dc44e
Details
license/cla All CLA requirements met.
Details
pr-e2e Build #20190529.9 succeeded
Details
pr-e2e (default_linux_e2e) default_linux_e2e succeeded
Details
pr-e2e (k8s_1_11_release_e2e) k8s_1_11_release_e2e succeeded
Details
pr-e2e (k8s_1_12_release_e2e) k8s_1_12_release_e2e succeeded
Details
pr-e2e (k8s_1_13_release_e2e) k8s_1_13_release_e2e succeeded
Details
pr-e2e (k8s_1_14_release_e2e) k8s_1_14_release_e2e succeeded
Details
pr-e2e (k8s_1_15_release_e2e) k8s_1_15_release_e2e succeeded
Details
pr-e2e (k8s_windows_1_12_release_e2e) k8s_windows_1_12_release_e2e succeeded
Details
pr-e2e (k8s_windows_1_13_release_e2e) k8s_windows_1_13_release_e2e succeeded
Details
pr-e2e (k8s_windows_1_14_release_e2e) k8s_windows_1_14_release_e2e succeeded
Details
pr-e2e (k8s_windows_1_15_release_e2e) k8s_windows_1_15_release_e2e succeeded
Details
pr-e2e (ubuntu_18_04_linux_e2e) ubuntu_18_04_linux_e2e succeeded
Details
pr-e2e (unit_tests) unit_tests succeeded
Details
tide In merge pool.
backlog automation moved this from Under Review to Done May 29, 2019
@feiskyer

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@CecileRobertMichon it's required for upstream pull-requests CI

CecileRobertMichon added a commit to CecileRobertMichon/aks-engine that referenced this pull request May 30, 2019
* fix: remove "allow-privileged" in kubelet 1.15.0

fix comments

* test: cover version-specific kubelet argument removals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.