Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: remove dependency on httpmock for Azure Stack unit tests #1589

Merged
merged 2 commits into from Jul 8, 2019

Conversation

chappleg
Copy link
Contributor

@chappleg chappleg commented Jul 8, 2019

Reason for Change:

See #1588

Issue Fixed:

#1588

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1589 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1589   +/-   ##
=======================================
  Coverage   76.23%   76.23%           
=======================================
  Files         129      129           
  Lines       18625    18625           
=======================================
  Hits        14198    14198           
  Misses       3645     3645           
  Partials      782      782

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@rjaini
Copy link
Contributor

rjaini commented Jul 8, 2019

lgtm

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jul 8, 2019
@CecileRobertMichon CecileRobertMichon merged commit c1b7a15 into Azure:master Jul 8, 2019
@acs-bot
Copy link

acs-bot commented Jul 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, t-chappl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chappleg chappleg deleted the fix-azs-unit-tests branch July 8, 2019 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants