Skip to content

Conversation

@ArcturusZhang
Copy link
Member

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash
Copy link
Member

m-nash commented Feb 13, 2023

Is this to be able to attach the debugger once it gets to the dotnet code in the generator? If so LGTM.

@ArcturusZhang
Copy link
Member Author

Is this to be able to attach the debugger once it gets to the dotnet code in the generator? If so LGTM.

Yes, we already have the flag in the generator to enable it to attach, but we are not passing the flag into the generator from the emitter.
This PR makes sure that we could pass in the flag through the emitter

@lirenhe
Copy link
Member

lirenhe commented Feb 21, 2023

I believe this has no impact for the SDK repo, could you confirm?

@ArcturusZhang
Copy link
Member Author

I believe this has no impact for the SDK repo, could you confirm?

definitely no change in SDK

@ArcturusZhang ArcturusZhang merged commit e3c1be2 into Azure:feature/v3 Feb 22, 2023
@ArcturusZhang ArcturusZhang deleted the emitter-support-debug branch February 22, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants