This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Feature: managed storage for clusters and jobs #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aztk/client.py
Outdated
| @@ -61,6 +61,9 @@ def __delete_pool_and_job(self, pool_id: str): | |||
|
|
|||
| if pool_exists: | |||
| self.batch_client.pool.delete(pool_id) | |||
|
|
|||
| cluster_data = self._get_cluster_data(pool_id) | |||
| cluster_data.delete_container(pool_id) | |||
There was a problem hiding this comment.
yeah this was a super simple change because of the cluster_data refactor
| @@ -22,6 +22,7 @@ def execute(args: typing.NamedTuple): | |||
| cluster_id = args.cluster_id | |||
|
|
|||
| if not args.force: | |||
| log.warn("All logs persisted for this cluster will be deleted.") | |||
There was a problem hiding this comment.
hhm, that does seem like a good idea
timotheeguerin
approved these changes
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #419
TODO:
--keep-logsflag to prevent storage deletion--keep-logsflag