Skip to content

configures survey messages and telemetry - #6793

Closed
Jesse Houwing (jessehouwing) wants to merge 8 commits into
Azure:mainfrom
jessehouwing:patch-1
Closed

configures survey messages and telemetry#6793
Jesse Houwing (jessehouwing) wants to merge 8 commits into
Azure:mainfrom
jessehouwing:patch-1

Conversation

@jessehouwing

@jessehouwing Jesse Houwing (jessehouwing) commented Sep 21, 2023

Copy link
Copy Markdown

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Adds settings for [core.survey_message](https://github.com/Azure/azure-cli/issues/25242) and core.collect_telemetry to az init.
Adds the following defaults:

  • Manual Mode
    • Survey=on
    • Telemetry=on
    • Auto-update=on
  • Automation Mode
    • Survey=off
    • Telemetry=off
    • Auto-update=off

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Sep 21, 2023

Copy link
Copy Markdown
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Jesse Houwing (@jessehouwing),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Jesse Houwing (@jessehouwing),
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 21, 2023
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for your contribution jessehouwing! We will review the pull request and get back to you soon.

@yonzhan

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@jessehouwing Jesse Houwing (jessehouwing) changed the title Asks whether to show the survey links configures survey messages and telemetry Sep 21, 2023
@jessehouwing

Copy link
Copy Markdown
Author

I tried running azdev style <YOUR_EXT> in the codespace, but it crashes.

@jessehouwing ➜ /workspaces/azure-cli-extensions (patch-1) $ azdev style init
Traceback (most recent call last):
  File "/home/codespace/.python/current/bin/azdev", line 8, in <module>
    sys.exit(main())
  File "/usr/local/python/3.10.8/lib/python3.10/site-packages/azdev/__main__.py", line 39, in main
    config_dir=get_azdev_config_dir())
  File "/usr/local/python/3.10.8/lib/python3.10/site-packages/azdev/utilities/config.py", line 24, in get_azdev_config_dir
    _, env_name = os.path.splitdrive(get_env_path())
  File "/usr/local/python/3.10.8/lib/python3.10/posixpath.py", line 134, in splitdrive
    p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not NoneType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants