Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS] Adding support for configuring a default ACS cluster #2554

Merged
merged 3 commits into from Mar 20, 2017
Merged
Changes from 2 commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -55,7 +55,7 @@ def _get_default_install_location(exe_name):

name_arg_type = CliArgumentType(options_list=('--name', '-n'), metavar='NAME')

register_cli_argument('acs', 'name', arg_type=name_arg_type, help='ACS cluster name', completer=get_resource_name_completion_list('Microsoft.ContainerService/ContainerServices'))
register_cli_argument('acs', 'name', arg_type=name_arg_type, configured_default='acs', help="ACS cluster name. You can configure the default using 'az configure --defaults acs=<name>'", completer=get_resource_name_completion_list('Microsoft.ContainerService/ContainerServices'))

This comment has been minimized.

Copy link
@troydai

troydai Mar 19, 2017

Contributor

I assume this file has disabled the pylint line-too-long rule, nevertheless, this is line is too long. Please break it to improve the readability.

This comment has been minimized.

Copy link
@lostintangent

lostintangent Mar 19, 2017

Author Contributor

@troydai Done!

register_cli_argument('acs', 'resource_group', arg_type=resource_group_name_type)

register_cli_argument('acs', 'orchestrator_type', **enum_choice_list(ContainerServiceOchestratorTypes))
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.